Chromium Code Reviews| OLD | NEW |
|---|---|
| 1 <div id="settings" class="page" hidden> | 1 <div id="settings" class="page" hidden> |
| 2 <header> | 2 <header> |
| 3 <h1 i18n-content="settingsTitle"></h1> | 3 <h1 i18n-content="settingsTitle"></h1> |
| 4 </header> | 4 </header> |
| 5 <if expr="not pp_ifdef('chromeos')"> | 5 <if expr="not pp_ifdef('chromeos')"> |
| 6 <include src="sync_section.html"> | 6 <include src="sync_section.html"> |
| 7 </if> | 7 </if> |
| 8 <if expr="pp_ifdef('chromeos')"> | 8 <if expr="pp_ifdef('chromeos')"> |
| 9 <section> | 9 <section> |
| 10 <h3 i18n-content="sectionTitleInternet"></h3> | 10 <h3 i18n-content="sectionTitleInternet"></h3> |
| (...skipping 728 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 739 </div> | 739 </div> |
| 740 <div class="option-name" id="accessibility-tap-dragging"> | 740 <div class="option-name" id="accessibility-tap-dragging"> |
| 741 <div class="checkbox"> | 741 <div class="checkbox"> |
| 742 <label> | 742 <label> |
| 743 <input id="accessibility-tap-dragging-check" | 743 <input id="accessibility-tap-dragging-check" |
| 744 pref="settings.touchpad.enable_tap_dragging" type="checkbox"> | 744 pref="settings.touchpad.enable_tap_dragging" type="checkbox"> |
| 745 <span i18n-content="accessibilityTapDragging"></span> | 745 <span i18n-content="accessibilityTapDragging"></span> |
| 746 </label> | 746 </label> |
| 747 </div> | 747 </div> |
| 748 </div> | 748 </div> |
| 749 <div class="setting-row" id="accessibility-autoclick" hidden> | |
| 750 <div class="checkbox"> | |
| 751 <input id="accessibility-autoclick-check" | |
| 752 pref="settings.a11y.autoclick" type="checkbox"> | |
| 753 </div> | |
| 754 <div id="accessibility-autoclick-subrow"> | |
| 755 <div> | |
| 756 <label for="accessibility-autoclick-check" | |
| 757 i18n-content="accessibilityAutoclick"> | |
| 758 </label> | |
| 759 <span class="controlled-setting-indicator" | |
| 760 pref="settings.a11y.autoclick"> | |
|
xiyuan
2013/10/15 15:52:33
<span> does not need to bind to a pref. Since you
Tim Song
2013/10/15 22:23:31
Don't we need this controlled-setting-indicator to
xiyuan
2013/10/15 23:59:37
I see. Totally missed that.
| |
| 761 </span> | |
| 762 </div> | |
| 763 <div> | |
| 764 <label class="option-name" for="accessibility-autoclick-dropdown" | |
| 765 i18n-content="accessibilityAutoclickDropdown"> | |
| 766 </label> | |
| 767 <select id="accessibility-autoclick-dropdown" class="control" | |
| 768 data-type="number" | |
| 769 pref="settings.a11y.autoclick_delay_ms"> | |
| 770 <option value="200" | |
| 771 i18n-content="autoclickDelayExtremelyShort"></option> | |
| 772 <option value="400" | |
| 773 i18n-content="autoclickDelayVeryShort"></option> | |
| 774 <option value="600" i18n-content="autoclickDelayShort"></option> | |
| 775 <option value="800" i18n-content="autoclickDelayLong"></option> | |
| 776 <option value="1000" | |
| 777 i18n-content="autoclickDelayVeryLong"></option> | |
| 778 </select> | |
| 779 <span class="controlled-setting-indicator" | |
| 780 pref="settings.a11y.autoclick_delay_ms"> | |
| 781 </span> | |
|
xiyuan
2013/10/15 15:52:33
This <span> could be removed too.
Tim Song
2013/10/15 22:23:31
Don't we need a bubble here here as well?
| |
| 782 </div> | |
| 783 </div> | |
| 784 </div> | |
| 749 </section> | 785 </section> |
| 750 <if expr="pp_ifdef('chromeos')"> | 786 <if expr="pp_ifdef('chromeos')"> |
| 751 <section id="factory-reset-section" hidden> | 787 <section id="factory-reset-section" hidden> |
| 752 <h3 i18n-content="factoryResetTitle"></h3> | 788 <h3 i18n-content="factoryResetTitle"></h3> |
| 753 <div> | 789 <div> |
| 754 <span class="settings-row" i18n-content="factoryResetDescription"> | 790 <span class="settings-row" i18n-content="factoryResetDescription"> |
| 755 </span> | 791 </span> |
| 756 <button id="factory-reset-restart" | 792 <button id="factory-reset-restart" |
| 757 i18n-content="factoryResetRestart"> | 793 i18n-content="factoryResetRestart"> |
| 758 </button> | 794 </button> |
| (...skipping 46 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 805 </div> | 841 </div> |
| 806 </section> | 842 </section> |
| 807 </div> <!-- advanced-settings-container --> | 843 </div> <!-- advanced-settings-container --> |
| 808 </div> <!-- advanced-settings --> | 844 </div> <!-- advanced-settings --> |
| 809 <footer> | 845 <footer> |
| 810 <button id="advanced-settings-expander" class="link-button" | 846 <button id="advanced-settings-expander" class="link-button" |
| 811 i18n-content="showAdvancedSettings"> | 847 i18n-content="showAdvancedSettings"> |
| 812 </button> | 848 </button> |
| 813 </footer> | 849 </footer> |
| 814 </div> | 850 </div> |
| OLD | NEW |