Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 271953002: Resubmit "Add an UMA metric to track whether running on a tablet". (Closed)

Created:
6 years, 7 months ago by zturner
Modified:
6 years, 7 months ago
CC:
chromium-reviews, erikwright+watch_chromium.org, jar (doing other things), asvitkine+watch_chromium.org
Visibility:
Public.

Description

Patch Set 1 : Original CL (issue 262773015) #

Patch Set 2 : Fix linking issues with powrprof and dependent targets. #

Patch Set 3 : Remove extraneous condition caused by merge. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+96 lines, -0 lines) Patch
M base/base.gyp View 1 2 2 chunks +50 lines, -0 lines 0 comments Download
M base/win/win_util.h View 1 chunk +5 lines, -0 lines 0 comments Download
M base/win/win_util.cc View 2 chunks +27 lines, -0 lines 0 comments Download
M chrome/browser/chrome_browser_main_win.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 2 chunks +10 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
zturner
Requesting re-review by thakis since base.gyp has changed. Everyone else to TBR since no other ...
6 years, 7 months ago (2014-05-08 19:27:40 UTC) #1
cpu_(ooo_6.6-7.5)
lgtm on base/win
6 years, 7 months ago (2014-05-08 22:10:59 UTC) #2
zturner
The CQ bit was checked by zturner@chromium.org
6 years, 7 months ago (2014-05-13 17:44:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zturner@chromium.org/271953002/40001
6 years, 7 months ago (2014-05-13 17:44:16 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-13 20:20:42 UTC) #5
commit-bot: I haz the power
6 years, 7 months ago (2014-05-13 21:15:16 UTC) #6
Message was sent while issue was closed.
Change committed as 270197

Powered by Google App Engine
This is Rietveld 408576698