Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(676)

Unified Diff: crypto/ec_private_key_unittest.cc

Issue 27195002: openssl: Implement crypto::ECPrivateKey. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« crypto/ec_private_key_openssl.cc ('K') | « crypto/ec_private_key_openssl.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: crypto/ec_private_key_unittest.cc
diff --git a/crypto/ec_private_key_unittest.cc b/crypto/ec_private_key_unittest.cc
index d2ec256deda7461cd6ef8626437c66a3fae8d196..0e30d9209503537cda8c5f5814e1e293d8034cb6 100644
--- a/crypto/ec_private_key_unittest.cc
+++ b/crypto/ec_private_key_unittest.cc
@@ -9,16 +9,9 @@
#include "base/memory/scoped_ptr.h"
#include "testing/gtest/include/gtest/gtest.h"
-#if defined(USE_OPENSSL)
-// Once ECPrivateKey is implemented for OpenSSL, remove this #if block.
-// TODO(mattm): When that happens, also add some exported keys from each to test
+// TODO(mattm): also add some exported keys from each to test
wtc 2013/10/14 21:45:07 Nit: remove "also".
digit1 2013/10/15 11:43:44 Done.
// interop between NSS and OpenSSL.
-TEST(ECPrivateKeyUnitTest, OpenSSLStub) {
- scoped_ptr<crypto::ECPrivateKey> keypair1(
- crypto::ECPrivateKey::Create());
- ASSERT_FALSE(keypair1.get());
-}
-#else
+
// Generate random private keys. Export, then re-import. We should get
// back the same exact public key, and the private key should have the same
// value and elliptic curve params.
@@ -103,5 +96,4 @@ TEST(ECPrivateKeyUnitTest, BadPasswordTest) {
crypto::ECPrivateKey::CreateFromEncryptedPrivateKeyInfo(
password2, privkey1, pubkey1));
ASSERT_FALSE(keypair2.get());
-}
-#endif // !defined(USE_OPENSSL)
+}
« crypto/ec_private_key_openssl.cc ('K') | « crypto/ec_private_key_openssl.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698