Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Issue 2719403004: Replace the sequence isInstanceOf/assign with assist-with-cast in ExpressionParserTestMixin. (Closed)

Created:
3 years, 9 months ago by scheglov
Modified:
3 years, 9 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Replace the sequence isInstanceOf/assign with assist-with-cast in ExpressionParserTestMixin. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/4d4275d36ec46c7f522e5d27b3f19deec53edefd

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+154 lines, -307 lines) Patch
M pkg/analyzer/test/generated/parser_test.dart View 153 chunks +154 lines, -307 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
3 years, 9 months ago (2017-02-28 22:15:08 UTC) #1
Brian Wilkerson
lgtm
3 years, 9 months ago (2017-02-28 22:18:12 UTC) #2
scheglov
3 years, 9 months ago (2017-02-28 22:31:48 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
4d4275d36ec46c7f522e5d27b3f19deec53edefd (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698