Get visibility into stability file accumulation

components/browser_watcher/postmortem_report_collector.cc

Index: components/browser_watcher/postmortem_report_collector.cc
diff --git a/components/browser_watcher/postmortem_report_collector.cc b/components/browser_watcher/postmortem_report_collector.cc
index 7f5bf1457b81517991d604bfc1a754b9ef75f950..deb200fd259af8a3311774c46852dfdb1f24df98 100644
--- a/components/browser_watcher/postmortem_report_collector.cc
+++ b/components/browser_watcher/postmortem_report_collector.cc
@@ -170,6 +170,8 @@ int PostmortemReportCollector::CollectAndSubmitForUpload(
   // Collect the list of files to harvest.
   std::vector<FilePath> debug_files = GetDebugStateFilePaths(
       debug_info_dir, debug_file_pattern, excluded_debug_files);
+  UMA_HISTOGRAM_COUNTS_100("ActivityTracker.Collect.StabilityFileCount",
+                           debug_files.size());
 
   // Determine the crashpad client id.
   crashpad::UUID client_id;
@@ -242,6 +244,7 @@ PostmortemReportCollector::CollectAndSubmit(
   CrashReportDatabase::OperationStatus database_status =
       report_database->PrepareNewCrashReport(&new_report);
   if (database_status != CrashReportDatabase::kNoError) {
+    // Assume this is recoverable: not deleting the file.
     LOG(ERROR) << "PrepareNewCrashReport failed";

[Sigurður Ásgeirsson, 2017/02/28 15:45:41]

Out of curiosity - how are these LOGs useful? Have you ever retrieved a log from
the field? Maybe it's better to use DLOG, and avoid bloating our shipped
binaries?

[manzagop (departed), 2017/02/28 16:07:39]

Done.

     return PREPARE_NEW_CRASH_REPORT_FAILED;
   }
@@ -251,6 +254,9 @@ PostmortemReportCollector::CollectAndSubmit(
   // Write the report to a minidump.
   if (!WriteReportToMinidump(report_proto.get(), client_id, new_report->uuid,
                              reinterpret_cast<FILE*>(new_report->handle))) {
+    // Assume this is not recoverable and delete the file.
+    if (!base::DeleteFile(file, false))
+      LOG(ERROR) << "Failed to delete " << file.value();
     return WRITE_TO_MINIDUMP_FAILED;
   }