net/cert/cert_verify_proc_ios.cc - Issue 2719273002: Disable commonName matching for certificates

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/cert/cert_verify_proc_ios.cc

Issue 2719273002: Disable commonName matching for certificates (Closed)

Patch Set: More ChromeOS fixes Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/cert/cert_verify_proc_ios.cc

diff --git a/net/cert/cert_verify_proc_ios.cc b/net/cert/cert_verify_proc_ios.cc

index 42746499e3b20f0d2fac4d37dbf30cb7fc3985e8..84ecd2aea84ba31730c706d83dc16c03ed414667 100644

--- a/net/cert/cert_verify_proc_ios.cc

+++ b/net/cert/cert_verify_proc_ios.cc

@@ -266,6 +266,9 @@ int CertVerifyProcIOS::VerifyInternal(

GetCertChainInfo(final_chain, verify_result);

+ // iOS lacks the ability to distinguish built-in versus non-built-in roots,

+ // so opt to 'fail open' of any restrictive policies that apply to built-in

+ // roots.

verify_result->is_issued_by_known_root = false;

if (IsCertStatusError(verify_result->cert_status))

« no previous file with comments | « net/cert/cert_verify_proc_android.cc ('k') | net/cert/cert_verify_proc_mac.cc » ('j') | no next file with comments »