ui/views/controls/combobox/combobox.cc - Issue 2719223002: Use correct position when setting pos_in_set for tabs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/views/controls/combobox/combobox.cc

Issue 2719223002: Use correct position when setting pos_in_set for tabs.

Patch Set: Potential nit. Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/views/controls/combobox/combobox.cc

diff --git a/ui/views/controls/combobox/combobox.cc b/ui/views/controls/combobox/combobox.cc

index cadbfa49efd367ed131bc4e0438cde90ddbe24d2..3c277e97596b4cf8b4a63f8e4c3548adcf998e5a 100644

--- a/ui/views/controls/combobox/combobox.cc

+++ b/ui/views/controls/combobox/combobox.cc

@@ -761,7 +761,8 @@ void Combobox::GetAccessibleNodeData(ui::AXNodeData* node_data) {

node_data->AddIntAttribute(ui::AX_ATTR_ACTION,

ui::AX_SUPPORTED_ACTION_OPEN);

}

- node_data->AddIntAttribute(ui::AX_ATTR_POS_IN_SET, selected_index_);

+ node_data->AddValidatedIntAttribute(ui::AX_ATTR_INDEX_IN_SET,

+ selected_index_);

node_data->AddIntAttribute(ui::AX_ATTR_SET_SIZE, model_->GetItemCount());

}