Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(591)

Unified Diff: runtime/vm/parser.cc

Issue 27192005: Add new style of string interpolation optimization: new nodes, working constant folding. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/intermediate_language_x64.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/parser.cc
===================================================================
--- runtime/vm/parser.cc (revision 28731)
+++ runtime/vm/parser.cc (working copy)
@@ -10070,7 +10070,7 @@
}
// Check if this interpolated string is still considered a compile time
// constant. If it is we need to evaluate if the current string part is
- // a constant or not. Only stings, numbers, booleans and null values
+ // a constant or not. Only strings, numbers, booleans and null values
// are allowed in compile time const interpolations.
if (is_compiletime_const) {
const Object* const_expr = expr->EvalConstExpr();
@@ -10091,16 +10091,11 @@
if (is_compiletime_const) {
primary = new LiteralNode(literal_start, Interpolate(values_list));
} else {
- ArgumentListNode* interpolate_arg = new ArgumentListNode(TokenPos());
ArrayNode* values = new ArrayNode(
TokenPos(),
Type::ZoneHandle(Type::ArrayType()),
values_list);
- interpolate_arg->Add(values);
- primary =
- MakeStaticCall(Symbols::StringBase(),
- Library::PrivateCoreLibName(Symbols::Interpolate()),
- interpolate_arg);
+ primary = new StringInterpolateNode(TokenPos(), values);
}
return primary;
}
« no previous file with comments | « runtime/vm/intermediate_language_x64.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698