Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(225)

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/w3c/local_wpt.py

Issue 2719173002: [WPT Export] Require GitHub API token in WPT remote origin URL (Closed)
Patch Set: Remove --depth, make LocalWPT.gh_token optional Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Tools/Scripts/webkitpy/w3c/local_wpt.py
diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/w3c/local_wpt.py b/third_party/WebKit/Tools/Scripts/webkitpy/w3c/local_wpt.py
index 6c9b0ecebf62a48f2f777851101cf72e20e00921..f4ce3e0c7f5d098b4dadb34050a352bc9de419dc 100644
--- a/third_party/WebKit/Tools/Scripts/webkitpy/w3c/local_wpt.py
+++ b/third_party/WebKit/Tools/Scripts/webkitpy/w3c/local_wpt.py
@@ -8,7 +8,7 @@ import logging
from webkitpy.common.system.executive import ScriptError
from webkitpy.w3c.chromium_commit import ChromiumCommit
-from webkitpy.w3c.common import WPT_GH_REPO_URL, CHROMIUM_WPT_DIR
+from webkitpy.w3c.common import WPT_GH_REPO_URL_TEMPLATE, CHROMIUM_WPT_DIR
_log = logging.getLogger(__name__)
@@ -16,7 +16,7 @@ _log = logging.getLogger(__name__)
class LocalWPT(object):
- def __init__(self, host, path='/tmp/wpt'):
+ def __init__(self, host, gh_token=None, path='/tmp/wpt'):
"""
Args:
host: A Host object.
@@ -26,16 +26,19 @@ class LocalWPT(object):
"""
self.host = host
self.path = path
+ self.gh_token = gh_token
self.branch_name = 'chromium-export-try'
def fetch(self):
+ assert self.gh_token, 'LocalWPT.gh_token required for fetch'
if self.host.filesystem.exists(self.path):
_log.info('WPT checkout exists at %s, fetching latest', self.path)
self.run(['git', 'fetch', 'origin'])
self.run(['git', 'checkout', 'origin/master'])
else:
- _log.info('Cloning %s into %s', WPT_GH_REPO_URL, self.path)
- self.host.executive.run_command(['git', 'clone', WPT_GH_REPO_URL, self.path])
+ _log.info('Cloning GitHub w3c/web-platform-tests into %s', self.path)
+ remote_url = WPT_GH_REPO_URL_TEMPLATE.format(self.gh_token)
+ self.host.executive.run_command(['git', 'clone', remote_url, self.path])
def run(self, command, **kwargs):
"""Runs a command in the local WPT directory."""

Powered by Google App Engine
This is Rietveld 408576698