Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(220)

Issue 2719163003: Update clang-format binaries and scripts for all platforms. (Closed)

Created:
3 years, 9 months ago by Nico
Modified:
3 years, 9 months ago
Reviewers:
Dan Beam
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
buildtools
Visibility:
Public.

Description

Update clang-format binaries and scripts for all platforms. I followed these instructions: https://chromium.googlesource.com/chromium/src/+/master/docs/updating_clang_format_binaries.md The binaries were built at clang revision 296408 on Mon Feb 27 Fixes several regressions in Objective-C formatting, and fixes a temp file leak on Windows. BUG=695885 TBR=dbeam Committed: b3771b1935ea74c388b6fb1750e83f5d83b39dec

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M clang_format/README.chromium View 1 chunk +1 line, -1 line 0 comments Download
M linux64/clang-format.sha1 View 1 chunk +1 line, -1 line 0 comments Download
M mac/clang-format.sha1 View 1 chunk +1 line, -1 line 0 comments Download
M win/clang-format.exe.sha1 View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (4 generated)
Nico
3 years, 9 months ago (2017-02-28 00:14:12 UTC) #3
Nico
Committed patchset #1 (id:1) manually as b3771b1935ea74c388b6fb1750e83f5d83b39dec (presubmit successful).
3 years, 9 months ago (2017-02-28 00:18:15 UTC) #6
Dan Beam
lgtm the win build didn't get smaller yet :(
3 years, 9 months ago (2017-02-28 00:32:37 UTC) #7
Nico
3 years, 9 months ago (2017-02-28 00:34:44 UTC) #8
Message was sent while issue was closed.
sorry fixing things to not write uninitialized memory all over our files
seemed like a more important thing to address first

On Mon, Feb 27, 2017 at 7:32 PM, <dbeam@chromium.org> wrote:

> lgtm
>
> the win build didn't get smaller yet :(
>
> https://codereview.chromium.org/2719163003/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

Powered by Google App Engine
This is Rietveld 408576698