Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(278)

Unified Diff: content/public/browser/renderer_unresponsive_type.h

Issue 2719133002: A page can't fire dialogs in unload handlers; remove code that handles that case. (Closed)
Patch Set: IPCs when closing? Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/browser/renderer_unresponsive_type.h
diff --git a/content/public/browser/renderer_unresponsive_type.h b/content/public/browser/renderer_unresponsive_type.h
index 34fa884eeb075447ce0450e0cf67beb44011ae5a..e2190f7dfe0b8a2555984ef4eb90a52a72f4b08f 100644
--- a/content/public/browser/renderer_unresponsive_type.h
+++ b/content/public/browser/renderer_unresponsive_type.h
@@ -17,7 +17,10 @@ enum RendererUnresponsiveType {
RENDERER_UNRESPONSIVE_DIALOG_CLOSED = 2,
RENDERER_UNRESPONSIVE_DIALOG_SUPPRESSED = 3,
RENDERER_UNRESPONSIVE_BEFORE_UNLOAD = 4,
- RENDERER_UNRESPONSIVE_UNLOAD = 5,
+
+ // Used when a page hangs after a JavaScript dialog is fired inside of unload.
+ // This is no longer allowed to happen so this value is no longer used.
+ RENDERER_UNRESPONSIVE_UNLOAD_OBSOLETE = 5,
RENDERER_UNRESPONSIVE_CLOSE_PAGE = 6,
RENDERER_UNRESPONSIVE_MAX = RENDERER_UNRESPONSIVE_CLOSE_PAGE,
};

Powered by Google App Engine
This is Rietveld 408576698