Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1037)

Side by Side Diff: content/browser/frame_host/render_frame_host_impl.h

Issue 2719133002: A page can't fire dialogs in unload handlers; remove code that handles that case. (Closed)
Patch Set: IPCs when closing? Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_BROWSER_FRAME_HOST_RENDER_FRAME_HOST_IMPL_H_ 5 #ifndef CONTENT_BROWSER_FRAME_HOST_RENDER_FRAME_HOST_IMPL_H_
6 #define CONTENT_BROWSER_FRAME_HOST_RENDER_FRAME_HOST_IMPL_H_ 6 #define CONTENT_BROWSER_FRAME_HOST_RENDER_FRAME_HOST_IMPL_H_
7 7
8 #include <stddef.h> 8 #include <stddef.h>
9 #include <stdint.h> 9 #include <stdint.h>
10 10
(...skipping 861 matching lines...) Expand 10 before | Expand all | Expand 10 after
872 // Callback for connection error on the media::mojom::InterfaceFactory client. 872 // Callback for connection error on the media::mojom::InterfaceFactory client.
873 void OnMediaInterfaceFactoryConnectionError(); 873 void OnMediaInterfaceFactoryConnectionError();
874 874
875 // Allows tests to disable the swapout event timer to simulate bugs that 875 // Allows tests to disable the swapout event timer to simulate bugs that
876 // happen before it fires (to avoid flakiness). 876 // happen before it fires (to avoid flakiness).
877 void DisableSwapOutTimerForTesting(); 877 void DisableSwapOutTimerForTesting();
878 878
879 void OnRendererConnect(const service_manager::ServiceInfo& local_info, 879 void OnRendererConnect(const service_manager::ServiceInfo& local_info,
880 const service_manager::ServiceInfo& remote_info); 880 const service_manager::ServiceInfo& remote_info);
881 881
882 void SendJavaScriptDialogReply(IPC::Message* reply_msg,
883 bool success,
884 const base::string16& user_input);
885
882 // Returns ownership of the NavigationHandle associated with a navigation that 886 // Returns ownership of the NavigationHandle associated with a navigation that
883 // just committed. 887 // just committed.
884 std::unique_ptr<NavigationHandleImpl> TakeNavigationHandleForCommit( 888 std::unique_ptr<NavigationHandleImpl> TakeNavigationHandleForCommit(
885 const FrameHostMsg_DidCommitProvisionalLoad_Params& params); 889 const FrameHostMsg_DidCommitProvisionalLoad_Params& params);
886 890
887 // For now, RenderFrameHosts indirectly keep RenderViewHosts alive via a 891 // For now, RenderFrameHosts indirectly keep RenderViewHosts alive via a
888 // refcount that calls Shutdown when it reaches zero. This allows each 892 // refcount that calls Shutdown when it reaches zero. This allows each
889 // RenderFrameHostManager to just care about RenderFrameHosts, while ensuring 893 // RenderFrameHostManager to just care about RenderFrameHosts, while ensuring
890 // we have a RenderViewHost for each RenderFrameHost. 894 // we have a RenderViewHost for each RenderFrameHost.
891 // TODO(creis): RenderViewHost will eventually go away and be replaced with 895 // TODO(creis): RenderViewHost will eventually go away and be replaced with
(...skipping 260 matching lines...) Expand 10 before | Expand all | Expand 10 after
1152 1156
1153 // NOTE: This must be the last member. 1157 // NOTE: This must be the last member.
1154 base::WeakPtrFactory<RenderFrameHostImpl> weak_ptr_factory_; 1158 base::WeakPtrFactory<RenderFrameHostImpl> weak_ptr_factory_;
1155 1159
1156 DISALLOW_COPY_AND_ASSIGN(RenderFrameHostImpl); 1160 DISALLOW_COPY_AND_ASSIGN(RenderFrameHostImpl);
1157 }; 1161 };
1158 1162
1159 } // namespace content 1163 } // namespace content
1160 1164
1161 #endif // CONTENT_BROWSER_FRAME_HOST_RENDER_FRAME_HOST_IMPL_H_ 1165 #endif // CONTENT_BROWSER_FRAME_HOST_RENDER_FRAME_HOST_IMPL_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698