Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issue 271913003: Fix webview tag's documentation to specify correct ClearDataTypeSet for clearData API. (Closed)

Created:
6 years, 7 months ago by lazyboy
Modified:
6 years, 7 months ago
Reviewers:
scheib, Fady Samuel
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Fix webview tag's documentation to specify correct ClearDataTypeSet for clearData API. BUG=371488 NOTRY=true Test=The preview link for this patch is: https://chrome-apps-doc.appspot.com/_patch/271913003/apps/tags/webview#type-ClearDataTypeSet Once the change is committed, this can be viewed in https://developer.chrome.com/apps/tags/webview#type-ClearDataTypeSet You should see only 6 items listed as types: appcache/cookies/fileSystems/indexedDB/localStorage/webSQL And it should not list unsupported items such as "downloads", "pluginData", ... which it does without this change. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269440

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -7 lines) Patch
M chrome/common/extensions/api/webview_tag.json View 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
lazyboy
6 years, 7 months ago (2014-05-08 19:15:31 UTC) #1
scheib
I'm happy to offer OWNERS approval here - but would like an lgtm from someone ...
6 years, 7 months ago (2014-05-08 20:44:23 UTC) #2
scheib
On 2014/05/08 20:44:23, scheib wrote: > I'm happy to offer OWNERS approval here - but ...
6 years, 7 months ago (2014-05-08 20:45:15 UTC) #3
Fady Samuel
webview API lgtm
6 years, 7 months ago (2014-05-08 21:26:51 UTC) #4
scheib
lgtm (intended this time ;)). Please fix up the change description.
6 years, 7 months ago (2014-05-08 21:35:07 UTC) #5
lazyboy
On 2014/05/08 20:45:15, scheib wrote: > On 2014/05/08 20:44:23, scheib wrote: > > I'm happy ...
6 years, 7 months ago (2014-05-08 21:58:35 UTC) #6
lazyboy
The CQ bit was checked by lazyboy@chromium.org
6 years, 7 months ago (2014-05-08 22:30:34 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/lazyboy@chromium.org/271913003/1
6 years, 7 months ago (2014-05-08 22:31:58 UTC) #8
commit-bot: I haz the power
6 years, 7 months ago (2014-05-09 22:34:49 UTC) #9
Message was sent while issue was closed.
Change committed as 269440

Powered by Google App Engine
This is Rietveld 408576698