Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Side by Side Diff: ash/frame/caption_buttons/frame_caption_button_container_view.cc

Issue 271913002: Animate window control changes in TouchView (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "ash/frame/caption_buttons/frame_caption_button_container_view.h" 5 #include "ash/frame/caption_buttons/frame_caption_button_container_view.h"
6 6
7 #include <cmath> 7 #include <cmath>
8 #include <map>
8 9
9 #include "ash/ash_switches.h" 10 #include "ash/ash_switches.h"
10 #include "ash/frame/caption_buttons/frame_caption_button.h" 11 #include "ash/frame/caption_buttons/frame_caption_button.h"
11 #include "ash/frame/caption_buttons/frame_size_button.h" 12 #include "ash/frame/caption_buttons/frame_size_button.h"
12 #include "ash/metrics/user_metrics_recorder.h" 13 #include "ash/metrics/user_metrics_recorder.h"
13 #include "ash/shell.h" 14 #include "ash/shell.h"
14 #include "grit/ui_strings.h" // Accessibility names 15 #include "grit/ui_strings.h" // Accessibility names
15 #include "ui/base/hit_test.h" 16 #include "ui/base/hit_test.h"
16 #include "ui/base/l10n/l10n_util.h" 17 #include "ui/base/l10n/l10n_util.h"
18 #include "ui/compositor/layer.h"
17 #include "ui/compositor/scoped_animation_duration_scale_mode.h" 19 #include "ui/compositor/scoped_animation_duration_scale_mode.h"
20 #include "ui/compositor/scoped_layer_animation_settings.h"
21 #include "ui/gfx/animation/tween.h"
18 #include "ui/gfx/canvas.h" 22 #include "ui/gfx/canvas.h"
19 #include "ui/gfx/insets.h" 23 #include "ui/gfx/insets.h"
20 #include "ui/gfx/point.h" 24 #include "ui/gfx/point.h"
21 #include "ui/views/widget/widget.h" 25 #include "ui/views/widget/widget.h"
22 #include "ui/views/widget/widget_delegate.h" 26 #include "ui/views/widget/widget_delegate.h"
23 27
24 namespace ash { 28 namespace ash {
25 29
26 namespace { 30 namespace {
27 31
32 // Visual design parameters for animating the transition to maximize mode.
33 // When the size button hides we delay sliding the minimize button into its
34 // location. Also used to delay showing the size button so that the minimize
35 // button slides out of that position.
36 const int kAnimationDelayMs = 100;
37 const int kMinimizeSlideDurationMs = 500;
38 const int kSizeFadeDurationMs = 250;
39
28 // Converts |point| from |src| to |dst| and hittests against |dst|. 40 // Converts |point| from |src| to |dst| and hittests against |dst|.
29 bool ConvertPointToViewAndHitTest(const views::View* src, 41 bool ConvertPointToViewAndHitTest(const views::View* src,
30 const views::View* dst, 42 const views::View* dst,
31 const gfx::Point& point) { 43 const gfx::Point& point) {
32 gfx::Point converted(point); 44 gfx::Point converted(point);
33 views::View::ConvertPointToTarget(src, dst, &converted); 45 views::View::ConvertPointToTarget(src, dst, &converted);
34 return dst->HitTestPoint(converted); 46 return dst->HitTestPoint(converted);
35 } 47 }
36 48
37 } // namespace 49 } // namespace
38 50
39 // static 51 // static
40 const char FrameCaptionButtonContainerView::kViewClassName[] = 52 const char FrameCaptionButtonContainerView::kViewClassName[] =
41 "FrameCaptionButtonContainerView"; 53 "FrameCaptionButtonContainerView";
42 54
43 FrameCaptionButtonContainerView::FrameCaptionButtonContainerView( 55 FrameCaptionButtonContainerView::FrameCaptionButtonContainerView(
44 views::Widget* frame, 56 views::Widget* frame,
45 MinimizeAllowed minimize_allowed) 57 MinimizeAllowed minimize_allowed)
46 : frame_(frame), 58 : frame_(frame),
47 minimize_button_(NULL), 59 minimize_button_(NULL),
48 size_button_(NULL), 60 size_button_(NULL),
49 close_button_(NULL) { 61 close_button_(NULL) {
62 SetPaintToLayer(true);
63 SetFillsBoundsOpaquely(false);
64
50 // Insert the buttons left to right. 65 // Insert the buttons left to right.
51 minimize_button_ = new FrameCaptionButton(this, CAPTION_BUTTON_ICON_MINIMIZE); 66 minimize_button_ = new FrameCaptionButton(this, CAPTION_BUTTON_ICON_MINIMIZE);
52 minimize_button_->SetAccessibleName( 67 minimize_button_->SetAccessibleName(
53 l10n_util::GetStringUTF16(IDS_APP_ACCNAME_MINIMIZE)); 68 l10n_util::GetStringUTF16(IDS_APP_ACCNAME_MINIMIZE));
54 minimize_button_->SetVisible(minimize_allowed == MINIMIZE_ALLOWED); 69 minimize_button_->SetVisible(minimize_allowed == MINIMIZE_ALLOWED);
70 minimize_button_->SetPaintToLayer(true);
71 minimize_button_->SetFillsBoundsOpaquely(false);
55 AddChildView(minimize_button_); 72 AddChildView(minimize_button_);
56 73
57 size_button_ = new FrameSizeButton(this, frame, this); 74 size_button_ = new FrameSizeButton(this, frame, this);
58 size_button_->SetAccessibleName( 75 size_button_->SetAccessibleName(
59 l10n_util::GetStringUTF16(IDS_APP_ACCNAME_MAXIMIZE)); 76 l10n_util::GetStringUTF16(IDS_APP_ACCNAME_MAXIMIZE));
77 size_button_->SetPaintToLayer(true);
78 size_button_->SetFillsBoundsOpaquely(false);
60 UpdateSizeButtonVisibility(false); 79 UpdateSizeButtonVisibility(false);
61 AddChildView(size_button_); 80 AddChildView(size_button_);
62 81
63 close_button_ = new FrameCaptionButton(this, CAPTION_BUTTON_ICON_CLOSE); 82 close_button_ = new FrameCaptionButton(this, CAPTION_BUTTON_ICON_CLOSE);
64 close_button_->SetAccessibleName( 83 close_button_->SetAccessibleName(
65 l10n_util::GetStringUTF16(IDS_APP_ACCNAME_CLOSE)); 84 l10n_util::GetStringUTF16(IDS_APP_ACCNAME_CLOSE));
85 close_button_->SetPaintToLayer(true);
86 close_button_->SetFillsBoundsOpaquely(false);
66 AddChildView(close_button_); 87 AddChildView(close_button_);
67 } 88 }
68 89
69 FrameCaptionButtonContainerView::~FrameCaptionButtonContainerView() { 90 FrameCaptionButtonContainerView::~FrameCaptionButtonContainerView() {
70 } 91 }
71 92
72 void FrameCaptionButtonContainerView::SetButtonImages( 93 void FrameCaptionButtonContainerView::SetButtonImages(
73 CaptionButtonIcon icon, 94 CaptionButtonIcon icon,
74 int icon_image_id, 95 int icon_image_id,
75 int inactive_icon_image_id, 96 int inactive_icon_image_id,
(...skipping 40 matching lines...) Expand 10 before | Expand all | Expand 10 after
116 ConvertPointToViewAndHitTest(this, minimize_button_, point)) { 137 ConvertPointToViewAndHitTest(this, minimize_button_, point)) {
117 return HTMINBUTTON; 138 return HTMINBUTTON;
118 } 139 }
119 return HTNOWHERE; 140 return HTNOWHERE;
120 } 141 }
121 142
122 void FrameCaptionButtonContainerView::UpdateSizeButtonVisibility( 143 void FrameCaptionButtonContainerView::UpdateSizeButtonVisibility(
123 bool force_hidden) { 144 bool force_hidden) {
124 // TODO(flackr): Refactor the Maximize Mode notifications. Currently 145 // TODO(flackr): Refactor the Maximize Mode notifications. Currently
125 // UpdateSizeButtonVisibilty requires a force_hidden parameter. This is 146 // UpdateSizeButtonVisibilty requires a force_hidden parameter. This is
126 // because Shell::IsMaximizeWindowManagerEnabled is still false at the 147 // because Shell::IsMaximizeWindowManagerEnabled is still false at the
oshima 2014/05/23 23:25:57 Can we fix this now (in separate CL)?
jonross 2014/05/29 15:45:43 This is currently being addressed in https://coder
127 // time when ShellObserver::OnMaximizeModeStarted is called. This prevents 148 // time when ShellObserver::OnMaximizeModeStarted is called. This prevents
128 // this method from performing that check, and instead relies on the calling 149 // this method from performing that check, and instead relies on the calling
129 // code to tell it to force being hidden. 150 // code to tell it to force being hidden.
130 size_button_->SetVisible( 151
131 !force_hidden && frame_->widget_delegate()->CanMaximize()); 152 bool visible = !force_hidden && frame_->widget_delegate()->CanMaximize();
153
154 // Turning visibility off prevents animations from rendering. Setting the
155 // size button visibility to false will occur after the animation.
156 if (visible) {
157 size_button_->SetVisible(visible);
oshima 2014/05/23 23:25:57 true (to be consistent with SetVisible below)
jonross 2014/05/29 15:45:43 Done.
158 // Because we delay calling View::SetVisible(false) until the end of the
159 // animation, if SetVisible(true) is called mid-animation, the View still
160 // believes it is visible and will not update the target layer visibility.
161 size_button_->layer()->SetVisible(true);
162 }
163
164 ui::ScopedLayerAnimationSettings settings(
165 size_button_->layer()->GetAnimator());
166 settings.SetTransitionDuration(
167 base::TimeDelta::FromMilliseconds(kSizeFadeDurationMs));
168 settings.SetPreemptionStrategy(
169 ui::LayerAnimator::IMMEDIATELY_ANIMATE_TO_NEW_TARGET);
170
171 if (visible) {
172 settings.SetTweenType(gfx::Tween::EASE_OUT);
173 // Delay fade in so that the minimize button has begun its sliding
174 // animation.
175 size_button_->layer()->GetAnimator()->SchedulePauseForProperties(
176 base::TimeDelta::FromMilliseconds(kAnimationDelayMs),
177 ui::LayerAnimationElement::OPACITY);
178 size_button_->layer()->SetOpacity(1.0f);
179 } else {
180 settings.SetTweenType(gfx::Tween::EASE_IN);
181 // Observer will call size_button_->SetVisible(false) upon completion of
182 // the animation.
183 // TODO(jonross): avoid the delayed SetVisible(false) call by acquring
184 // the size_button's layer before making it invisible. That layer can then
185 // be animated and deleted upon completion of the animation. See
186 // LayerOwner::RecreateLayer
187 settings.AddObserver(this);
188 size_button_->layer()->SetOpacity(0.0f);
189 size_button_->layer()->SetVisible(false);
190 }
132 } 191 }
133 192
134 gfx::Size FrameCaptionButtonContainerView::GetPreferredSize() const { 193 gfx::Size FrameCaptionButtonContainerView::GetPreferredSize() const {
135 int width = 0; 194 int width = 0;
136 for (int i = 0; i < child_count(); ++i) { 195 for (int i = 0; i < child_count(); ++i) {
137 const views::View* child = child_at(i); 196 const views::View* child = child_at(i);
138 if (child->visible()) 197 if (child->visible())
139 width += child_at(i)->GetPreferredSize().width(); 198 width += child_at(i)->GetPreferredSize().width();
140 } 199 }
141 return gfx::Size(width, close_button_->GetPreferredSize().height()); 200 return gfx::Size(width, close_button_->GetPreferredSize().height());
142 } 201 }
143 202
144 void FrameCaptionButtonContainerView::Layout() { 203 void FrameCaptionButtonContainerView::Layout() {
145 int x = 0; 204 int x = width();
146 for (int i = 0; i < child_count(); ++i) { 205 // Offsets the initial position of a child, so that buttons slide into the
206 // place as other buttons are added/removed.
207 int offset_x = 0;
208 for (int i = child_count() - 1; i >= 0; --i) {
147 views::View* child = child_at(i); 209 views::View* child = child_at(i);
148 if (!child->visible()) 210 ui::LayerAnimator* child_animator = child->layer()->GetAnimator();
211 bool child_animating = child_animator->is_animating();
212 // The actual property visibility is not being animated, otherwise the
213 // view does not render.
214 bool child_animating_opacity = child_animator->
215 IsAnimatingProperty(ui::LayerAnimationElement::OPACITY);
216 bool child_target_visibility = child->layer()->GetTargetVisibility();
217
218 if (child_animating_opacity) {
219 if (child_target_visibility)
220 offset_x += child->width();
221 else
222 offset_x -= child->width();
223 }
224
225 if (!child->visible() || !child_target_visibility)
149 continue; 226 continue;
150 227
228 scoped_ptr<ui::ScopedLayerAnimationSettings> animation;
151 gfx::Size size = child->GetPreferredSize(); 229 gfx::Size size = child->GetPreferredSize();
230 x -= size.width();
231
232 // Animate the button if a previous button is currently animating
233 // its visibility.
234 if (offset_x != 0) {
235 if (!child_animating)
236 child->SetBounds(x + offset_x, 0, size.width(), size.height());
237 if (offset_x < 0) {
238 // Delay sliding to where the previous button was located.
239 child_animator->SchedulePauseForProperties(
240 base::TimeDelta::FromMilliseconds(kAnimationDelayMs),
241 ui::LayerAnimationElement::BOUNDS);
242 }
243
244 ui::ScopedLayerAnimationSettings* settings =
245 new ui::ScopedLayerAnimationSettings(child_animator);
246 settings->SetTransitionDuration(
247 base::TimeDelta::FromMilliseconds(kMinimizeSlideDurationMs));
248 settings->SetPreemptionStrategy(
249 ui::LayerAnimator::IMMEDIATELY_ANIMATE_TO_NEW_TARGET);
250 settings->SetTweenType(gfx::Tween::EASE_OUT);
251 animation.reset(settings);
252 }
152 child->SetBounds(x, 0, size.width(), size.height()); 253 child->SetBounds(x, 0, size.width(), size.height());
153 x += size.width();
154 } 254 }
155 } 255 }
156 256
157 const char* FrameCaptionButtonContainerView::GetClassName() const { 257 const char* FrameCaptionButtonContainerView::GetClassName() const {
158 return kViewClassName; 258 return kViewClassName;
159 } 259 }
160 260
161 void FrameCaptionButtonContainerView::SetButtonIcon(FrameCaptionButton* button, 261 void FrameCaptionButtonContainerView::SetButtonIcon(FrameCaptionButton* button,
162 CaptionButtonIcon icon, 262 CaptionButtonIcon icon,
163 Animate animate) { 263 Animate animate) {
(...skipping 31 matching lines...) Expand 10 before | Expand all | Expand 10 after
195 } 295 }
196 296
197 // Abort any animations of the button icons. 297 // Abort any animations of the button icons.
198 SetButtonsToNormal(ANIMATE_NO); 298 SetButtonsToNormal(ANIMATE_NO);
199 299
200 ash::UserMetricsAction action = 300 ash::UserMetricsAction action =
201 ash::UMA_WINDOW_MAXIMIZE_BUTTON_CLICK_MINIMIZE; 301 ash::UMA_WINDOW_MAXIMIZE_BUTTON_CLICK_MINIMIZE;
202 if (sender == minimize_button_) { 302 if (sender == minimize_button_) {
203 frame_->Minimize(); 303 frame_->Minimize();
204 } else if (sender == size_button_) { 304 } else if (sender == size_button_) {
205 if (frame_->IsFullscreen()) { // Can be clicked in immersive fullscreen. 305 if (frame_->IsFullscreen()) { // Can be clicked in immersive fullscreen.
206 frame_->SetFullscreen(false); 306 frame_->SetFullscreen(false);
207 action = ash::UMA_WINDOW_MAXIMIZE_BUTTON_CLICK_EXIT_FULLSCREEN; 307 action = ash::UMA_WINDOW_MAXIMIZE_BUTTON_CLICK_EXIT_FULLSCREEN;
208 } else if (frame_->IsMaximized()) { 308 } else if (frame_->IsMaximized()) {
209 frame_->Restore(); 309 frame_->Restore();
210 action = ash::UMA_WINDOW_MAXIMIZE_BUTTON_CLICK_RESTORE; 310 action = ash::UMA_WINDOW_MAXIMIZE_BUTTON_CLICK_RESTORE;
211 } else { 311 } else {
212 frame_->Maximize(); 312 frame_->Maximize();
213 action = ash::UMA_WINDOW_MAXIMIZE_BUTTON_CLICK_MAXIMIZE; 313 action = ash::UMA_WINDOW_MAXIMIZE_BUTTON_CLICK_MAXIMIZE;
214 } 314 }
215 } else if(sender == close_button_) { 315 } else if (sender == close_button_) {
216 frame_->Close(); 316 frame_->Close();
217 action = ash::UMA_WINDOW_CLOSE_BUTTON_CLICK; 317 action = ash::UMA_WINDOW_CLOSE_BUTTON_CLICK;
218 } else { 318 } else {
219 return; 319 return;
220 } 320 }
221 ash::Shell::GetInstance()->metrics()->RecordUserMetricsAction(action); 321 ash::Shell::GetInstance()->metrics()->RecordUserMetricsAction(action);
222 } 322 }
223 323
224 bool FrameCaptionButtonContainerView::IsMinimizeButtonVisible() const { 324 bool FrameCaptionButtonContainerView::IsMinimizeButtonVisible() const {
225 return minimize_button_->visible(); 325 return minimize_button_->visible();
(...skipping 56 matching lines...) Expand 10 before | Expand all | Expand 10 after
282 FrameCaptionButton* button = buttons[i]; 382 FrameCaptionButton* button = buttons[i];
283 views::Button::ButtonState new_state = views::Button::STATE_NORMAL; 383 views::Button::ButtonState new_state = views::Button::STATE_NORMAL;
284 if (button == to_hover) 384 if (button == to_hover)
285 new_state = views::Button::STATE_HOVERED; 385 new_state = views::Button::STATE_HOVERED;
286 else if (button == to_press) 386 else if (button == to_press)
287 new_state = views::Button::STATE_PRESSED; 387 new_state = views::Button::STATE_PRESSED;
288 button->SetState(new_state); 388 button->SetState(new_state);
289 } 389 }
290 } 390 }
291 391
392 void FrameCaptionButtonContainerView::OnImplicitAnimationsCompleted() {
393 // If there is another animation in the queue, the reverse animation was
394 // triggered before the completion of animating to invisible. Do not turn off
395 // the visibility so that the next animation may render.
396 if (!size_button_->layer()->GetAnimator()->is_animating() &&
397 !size_button_->layer()->GetTargetVisibility()) {
398 size_button_->SetVisible(false);
399 }
400 // TODO(jonross): currently we need to delay telling the parent about the
401 // size change from visibility. When the size changes this forces a relayout
402 // and we want to animate both the bounds of FrameCaptionButtonContainerView
403 // along with that of its children. However when the parent is currently
404 // having its bounds changed this leads to strange animations where this view
405 // renders outside of its parents. Create a more specific animation where
406 // height and y are immediately fixed, and where we only animate width and x.
407 PreferredSizeChanged();
408 }
409
292 FrameCaptionButtonContainerView::ButtonIconIds::ButtonIconIds() 410 FrameCaptionButtonContainerView::ButtonIconIds::ButtonIconIds()
293 : icon_image_id(-1), 411 : icon_image_id(-1),
294 inactive_icon_image_id(-1), 412 inactive_icon_image_id(-1),
295 hovered_background_image_id(-1), 413 hovered_background_image_id(-1),
296 pressed_background_image_id(-1) { 414 pressed_background_image_id(-1) {
297 } 415 }
298 416
299 FrameCaptionButtonContainerView::ButtonIconIds::ButtonIconIds( 417 FrameCaptionButtonContainerView::ButtonIconIds::ButtonIconIds(
300 int icon_id, 418 int icon_id,
301 int inactive_icon_id, 419 int inactive_icon_id,
302 int hovered_background_id, 420 int hovered_background_id,
303 int pressed_background_id) 421 int pressed_background_id)
304 : icon_image_id(icon_id), 422 : icon_image_id(icon_id),
305 inactive_icon_image_id(inactive_icon_id), 423 inactive_icon_image_id(inactive_icon_id),
306 hovered_background_image_id(hovered_background_id), 424 hovered_background_image_id(hovered_background_id),
307 pressed_background_image_id(pressed_background_id) { 425 pressed_background_image_id(pressed_background_id) {
308 } 426 }
309 427
310 FrameCaptionButtonContainerView::ButtonIconIds::~ButtonIconIds() { 428 FrameCaptionButtonContainerView::ButtonIconIds::~ButtonIconIds() {
311 } 429 }
312 430
313 } // namespace ash 431 } // namespace ash
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698