third_party/WebKit/Source/core/animation/KeyframeEffectReadOnly.cpp - Issue 2719083005: Use PropertyHandle instead of CSSPropertyID to identify CSS Transitions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/animation/KeyframeEffectReadOnly.cpp

Issue 2719083005: Use PropertyHandle instead of CSSPropertyID to identify CSS Transitions (Closed)

Patch Set: Rebasedagainaaaa Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/animation/KeyframeEffectReadOnly.h ('k') | third_party/WebKit/Source/core/animation/css/CSSAnimationUpdate.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/animation/KeyframeEffectReadOnly.cpp

diff --git a/third_party/WebKit/Source/core/animation/KeyframeEffectReadOnly.cpp b/third_party/WebKit/Source/core/animation/KeyframeEffectReadOnly.cpp

index 62169ab76a67887a79619b90a23a4da218e58f30..3b97beff90a78becb2fe419b63644ec0aeb1197c 100644

--- a/third_party/WebKit/Source/core/animation/KeyframeEffectReadOnly.cpp

+++ b/third_party/WebKit/Source/core/animation/KeyframeEffectReadOnly.cpp

@@ -313,11 +313,11 @@ bool KeyframeEffectReadOnly::hasActiveAnimationsOnCompositor() const {

}

bool KeyframeEffectReadOnly::hasActiveAnimationsOnCompositor(

- CSSPropertyID property) const {

- return hasActiveAnimationsOnCompositor() && affects(PropertyHandle(property));

+ const PropertyHandle& property) const {

+ return hasActiveAnimationsOnCompositor() && affects(property);

}

-bool KeyframeEffectReadOnly::affects(PropertyHandle property) const {

+bool KeyframeEffectReadOnly::affects(const PropertyHandle& property) const {

return m_model && m_model->affects(property);

}