third_party/WebKit/Source/core/animation/EffectStack.cpp - Issue 2719083005: Use PropertyHandle instead of CSSPropertyID to identify CSS Transitions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/animation/EffectStack.cpp

Issue 2719083005: Use PropertyHandle instead of CSSPropertyID to identify CSS Transitions (Closed)

Patch Set: Rebasedagainaaaa Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/animation/EffectStack.cpp

diff --git a/third_party/WebKit/Source/core/animation/EffectStack.cpp b/third_party/WebKit/Source/core/animation/EffectStack.cpp

index e136381f5c9bec9183c5e47bd052847957d640ce..f26519e6df92664738b8318a49bde15b81e39201 100644

--- a/third_party/WebKit/Source/core/animation/EffectStack.cpp

+++ b/third_party/WebKit/Source/core/animation/EffectStack.cpp

@@ -88,7 +88,7 @@ void copyNewAnimationsToActiveInterpolationsMap(

EffectStack::EffectStack() {}

bool EffectStack::hasActiveAnimationsOnCompositor(

- CSSPropertyID property) const {

+ const PropertyHandle& property) const {

for (const auto& sampledEffect : m_sampledEffects) {

// TODO(dstockwell): move the playing check into AnimationEffectReadOnly and

// expose both hasAnimations and hasActiveAnimations