Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2719083004: Fix build failures in precompiled runtime (Closed)

Created:
3 years, 9 months ago by Cutch
Modified:
3 years, 9 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix build failures in precompiled runtime BUG= Committed: https://github.com/dart-lang/sdk/commit/4fe4f177dead7039879441f8c4ba4836727b0317

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -8 lines) Patch
M runtime/vm/object.h View 1 chunk +1 line, -8 lines 0 comments Download
M runtime/vm/object.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M runtime/vm/object_service.cc View 1 chunk +2 lines, -0 lines 1 comment Download

Messages

Total messages: 6 (3 generated)
Cutch
Committed patchset #1 (id:1) manually as 4fe4f177dead7039879441f8c4ba4836727b0317 (presubmit successful).
3 years, 9 months ago (2017-02-27 22:36:27 UTC) #2
Cutch
TBR
3 years, 9 months ago (2017-02-27 22:36:44 UTC) #5
rmacnak
3 years, 9 months ago (2017-02-27 22:38:18 UTC) #6
Message was sent while issue was closed. 
lgtm

https://codereview.chromium.org/2719083004/diff/1/runtime/vm/object_service.cc
File runtime/vm/object_service.cc (right):

https://codereview.chromium.org/2719083004/diff/1/runtime/vm/object_service.c...
runtime/vm/object_service.cc:875: #endif
else UNREACHABLE

Powered by Google App Engine
This is Rietveld 408576698