IndexedDB: Optimize range deletion operations (e.g. clearing a store)

content/browser/indexed_db/indexed_db_backing_store_unittest.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/indexed_db/indexed_db_backing_store.h"
 
 #include <stddef.h>
 #include <stdint.h>
 #include <utility>
 
@@ skipping 455 matching lines @@
     EXPECT_TRUE(transaction2.CommitPhaseTwo().ok());
     EXPECT_EQ(m_value3.bits, result_value.bits);
     EXPECT_TRUE(CheckBlobInfoMatches(result_value.blob_info));
     EXPECT_TRUE(CheckBlobReadsMatchWrites(result_value.blob_info));
   }
 
   {
     IndexedDBBackingStore::Transaction transaction3(backing_store_.get());
     transaction3.Begin();
     IndexedDBValue result_value;
-    size_t delete_count = 0;
-    EXPECT_TRUE(backing_store_
-                    ->DeleteRange(&transaction3, 1, 1,
-                                  IndexedDBKeyRange(m_key3), &delete_count)
-                    .ok());
-    EXPECT_EQ(1UL, delete_count);
+    EXPECT_TRUE(
+        backing_store_
+            ->DeleteRange(&transaction3, 1, 1, IndexedDBKeyRange(m_key3))
+            .ok());
     scoped_refptr<TestCallback> callback(new TestCallback());
     EXPECT_TRUE(transaction3.CommitPhaseOne(callback).ok());
     task_runner_->RunUntilIdle();
     EXPECT_TRUE(callback->called);
     EXPECT_TRUE(callback->succeeded);
     EXPECT_TRUE(transaction3.CommitPhaseTwo().ok());
     EXPECT_TRUE(CheckBlobRemovals());
   }
 }
 
@@ skipping 64 matching lines @@
       task_runner_->RunUntilIdle();
       EXPECT_TRUE(callback->called);
       EXPECT_TRUE(callback->succeeded);
       EXPECT_TRUE(transaction1.CommitPhaseTwo().ok());
     }
 
     {
       IndexedDBBackingStore::Transaction transaction2(backing_store_.get());
       transaction2.Begin();
       IndexedDBValue result_value;
-      size_t delete_count = 0;
       EXPECT_TRUE(
-          backing_store_
-              ->DeleteRange(&transaction2, 1, i + 1, ranges[i], &delete_count)
-              .ok());
-      EXPECT_EQ(2UL, delete_count);
+          backing_store_->DeleteRange(&transaction2, 1, i + 1, ranges[i]).ok());
       scoped_refptr<TestCallback> callback(new TestCallback());
       EXPECT_TRUE(transaction2.CommitPhaseOne(callback).ok());
       task_runner_->RunUntilIdle();
       EXPECT_TRUE(callback->called);
       EXPECT_TRUE(callback->succeeded);
       EXPECT_TRUE(transaction2.CommitPhaseTwo().ok());
       ASSERT_EQ(2UL, backing_store_->removals().size());
       EXPECT_EQ(backing_store_->writes()[1].key(),
                 backing_store_->removals()[0]);
       EXPECT_EQ(backing_store_->writes()[2].key(),
@@ skipping 68 matching lines @@
       task_runner_->RunUntilIdle();
       EXPECT_TRUE(callback->called);
       EXPECT_TRUE(callback->succeeded);
       EXPECT_TRUE(transaction1.CommitPhaseTwo().ok());
     }
 
     {
       IndexedDBBackingStore::Transaction transaction2(backing_store_.get());
       transaction2.Begin();
       IndexedDBValue result_value;
-      size_t delete_count = 0;
       EXPECT_TRUE(
-          backing_store_
-              ->DeleteRange(&transaction2, 1, i + 1, ranges[i], &delete_count)
-              .ok());
-      EXPECT_EQ(0UL, delete_count);
+          backing_store_->DeleteRange(&transaction2, 1, i + 1, ranges[i]).ok());
       scoped_refptr<TestCallback> callback(new TestCallback());
       EXPECT_TRUE(transaction2.CommitPhaseOne(callback).ok());
       task_runner_->RunUntilIdle();
       EXPECT_TRUE(callback->called);
       EXPECT_TRUE(callback->succeeded);
       EXPECT_TRUE(transaction2.CommitPhaseTwo().ok());
       EXPECT_EQ(0UL, backing_store_->removals().size());
     }
   }
 }
@@ skipping 73 matching lines @@
     EXPECT_TRUE(CheckBlobInfoMatches(read_result_value.blob_info));
     EXPECT_TRUE(CheckBlobReadsMatchWrites(read_result_value.blob_info));
     for (size_t i = 0; i < read_result_value.blob_info.size(); ++i) {
       read_result_value.blob_info[i].mark_used_callback().Run();
     }
   }
 
   {
     IndexedDBBackingStore::Transaction transaction3(backing_store_.get());
     transaction3.Begin();
-    size_t delete_count = 0;
-    EXPECT_TRUE(backing_store_
-                    ->DeleteRange(&transaction3, 1, 1,
-                                  IndexedDBKeyRange(m_key3), &delete_count)
-                    .ok());
-    EXPECT_EQ(1UL, delete_count);
+    EXPECT_TRUE(
+        backing_store_
+            ->DeleteRange(&transaction3, 1, 1, IndexedDBKeyRange(m_key3))
+            .ok());
     scoped_refptr<TestCallback> callback(new TestCallback());
     EXPECT_TRUE(transaction3.CommitPhaseOne(callback).ok());
     task_runner_->RunUntilIdle();
     EXPECT_TRUE(callback->called);
     EXPECT_TRUE(callback->succeeded);
     EXPECT_TRUE(transaction3.CommitPhaseTwo().ok());
     EXPECT_EQ(0U, backing_store_->removals().size());
     for (size_t i = 0; i < read_result_value.blob_info.size(); ++i) {
       read_result_value.blob_info[i].release_callback().Run(
           read_result_value.blob_info[i].file_path());
@@ skipping 383 matching lines @@
 
   // Dictionary, message key and more.
   ASSERT_TRUE(WriteFile(info_path, "{\"message\":\"foo\",\"bar\":5}"));
   EXPECT_TRUE(
       IndexedDBBackingStore::ReadCorruptionInfo(path_base, origin, &message));
   EXPECT_FALSE(PathExists(info_path));
   EXPECT_EQ("foo", message);
 }
 
 }  // namespace content