Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(974)

Unified Diff: runtime/vm/message_handler.cc

Issue 271893002: Add trace_service_pause_events flag and related tracing (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/bin/vmservice/server.dart ('k') | runtime/vm/service.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/message_handler.cc
diff --git a/runtime/vm/message_handler.cc b/runtime/vm/message_handler.cc
index 32756b8f2489c4ea247ddc29c1ef47daaec5c501..b1064a280b7cf9085963d74b95cb0d6336b170c2 100644
--- a/runtime/vm/message_handler.cc
+++ b/runtime/vm/message_handler.cc
@@ -9,7 +9,7 @@
namespace dart {
DECLARE_FLAG(bool, trace_isolates);
-
+DECLARE_FLAG(bool, trace_service_pause_events);
class MessageHandlerTask : public ThreadPool::Task {
public:
@@ -231,6 +231,10 @@ void MessageHandler::TaskCallback() {
if (!ok || !HasLivePorts()) {
if (pause_on_exit()) {
+ if (FLAG_trace_service_pause_events && !paused_on_exit_) {
+ OS::PrintErr("Isolate %s paused before exiting. "
+ "Use the Observatory to release it.\n", name());
+ }
paused_on_exit_ = true;
} else {
if (FLAG_trace_isolates) {
« no previous file with comments | « runtime/bin/vmservice/server.dart ('k') | runtime/vm/service.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698