Refactor unreliable hit test code to avoid owning_layers

cc/trees/layer_tree_impl.cc

Index: cc/trees/layer_tree_impl.cc
diff --git a/cc/trees/layer_tree_impl.cc b/cc/trees/layer_tree_impl.cc
index 5d91fc703c8436df4fa9f432099b4a3e1b2039a9..fae5f7c6d62f063e7e0508d78287300a3795fe1a 100644
--- a/cc/trees/layer_tree_impl.cc
+++ b/cc/trees/layer_tree_impl.cc
@@ -1929,32 +1929,26 @@ static void FindClosestMatchingLayer(const gfx::PointF& screen_space_point,
   }
 }
 
-static bool IsScrollableOrDrawnScrollbarLayer(LayerImpl* layer) {
-  return layer->scrollable() ||
-         (layer->ToScrollbarLayer() &&
-          layer->is_drawn_render_surface_layer_list_member());
-}
-
-struct FindScrollingLayerOrScrollbarLayerFunctor {
+struct FindScrollingLayerOrDrawnScrollbarFunctor {
   bool operator()(LayerImpl* layer) const {
-    return IsScrollableOrDrawnScrollbarLayer(layer);
+    return layer->scrollable() || layer->IsDrawnScrollbar();
   }
 };
 
 LayerImpl*
-LayerTreeImpl::FindFirstScrollingLayerOrScrollbarLayerThatIsHitByPoint(
+LayerTreeImpl::FindFirstScrollingLayerOrDrawnScrollbarThatIsHitByPoint(
     const gfx::PointF& screen_space_point) {
   FindClosestMatchingLayerState state;
   LayerImpl* root_layer = layer_list_.empty() ? nullptr : layer_list_[0];
   FindClosestMatchingLayer(screen_space_point, root_layer,
-                           FindScrollingLayerOrScrollbarLayerFunctor(), &state);
+                           FindScrollingLayerOrDrawnScrollbarFunctor(), &state);
   return state.closest_match;
 }
 
 struct HitTestVisibleScrollableOrTouchableFunctor {
   bool operator()(LayerImpl* layer) const {
-    return layer->is_drawn_render_surface_layer_list_member() ||
-           IsScrollableOrDrawnScrollbarLayer(layer) ||
+    return layer->scrollable() ||

[pdr., 2017/02/27 21:40:05]

The original code was really checking the following:
if (layer->is_drawn_render_surface_layer_list_member()
  || layer->scrollable()
  || (layer->ToScrollbarLayer() &&
layer->is_drawn_render_surface_layer_list_member())
  || !layer->touch_event_handler_region().IsEmpty())

This checked is_drawn_render_surface_layer_list_member twice, and can be
refactored to only do it once.

+           layer->is_drawn_render_surface_layer_list_member() ||
            !layer->touch_event_handler_region().IsEmpty();
   }
 };