DescriptionFixed ExtensionUpdaterTest.TestMultipleManifestDownloading.
This test assumed that the ExtensionDownloader schedules its fetchers
in the order that StartUpdateCheck() is called, when downloading more
than one ManifestFetchData. However, the ExtensionDownloader was updated
in http://crrev.com/171540 to use a RequestQueue, which schedules the
fetchers using a heap.
That heap sorts the requests by time to the next retry, which is 0
for all requests initially. The test didn't break before because
std::push_heap and std::pop_heap in all STL implementations used
happen to keep the same order when all requests have the same
priority (!). This assumption broke under TSAN/MSAN builds because
they use libc++, whose std::pop_heap changes the order of the
execution of the fetches.
This fix makes the test support its fetches in any order.
BUG=358712
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269554
Patch Set 1 #Patch Set 2 : enable test #Messages
Total messages: 5 (0 generated)
|