Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 271873002: Fixed ExtensionUpdaterTest.TestMultipleManifestDownloading. (Closed)

Created:
6 years, 7 months ago by Joao da Silva
Modified:
6 years, 7 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Visibility:
Public.

Description

Fixed ExtensionUpdaterTest.TestMultipleManifestDownloading. This test assumed that the ExtensionDownloader schedules its fetchers in the order that StartUpdateCheck() is called, when downloading more than one ManifestFetchData. However, the ExtensionDownloader was updated in http://crrev.com/171540 to use a RequestQueue, which schedules the fetchers using a heap. That heap sorts the requests by time to the next retry, which is 0 for all requests initially. The test didn't break before because std::push_heap and std::pop_heap in all STL implementations used happen to keep the same order when all requests have the same priority (!). This assumption broke under TSAN/MSAN builds because they use libc++, whose std::pop_heap changes the order of the execution of the fetches. This fix makes the test support its fetches in any order. BUG=358712 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269554

Patch Set 1 #

Patch Set 2 : enable test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+106 lines, -96 lines) Patch
M chrome/browser/extensions/updater/extension_updater_unittest.cc View 1 3 chunks +106 lines, -96 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Joao da Silva
PTAL, thanks!
6 years, 7 months ago (2014-05-08 11:31:20 UTC) #1
Marijn Kruisselbrink
LGTM, thanks for fixing this
6 years, 7 months ago (2014-05-08 20:41:48 UTC) #2
Joao da Silva
The CQ bit was checked by joaodasilva@chromium.org
6 years, 7 months ago (2014-05-09 07:24:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/joaodasilva@chromium.org/271873002/20001
6 years, 7 months ago (2014-05-09 07:31:15 UTC) #4
commit-bot: I haz the power
6 years, 7 months ago (2014-05-10 07:50:11 UTC) #5
Message was sent while issue was closed.
Change committed as 269554

Powered by Google App Engine
This is Rietveld 408576698