Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Issue 2718723003: Fixed issue where MallocHooks tests would try and re-initialize the hooks and ended up hitting an a… (Closed)

Created:
3 years, 10 months ago by bkonyi
Modified:
3 years, 10 months ago
Reviewers:
zra, Cutch
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fixed issue where MallocHooks tests would try and re-initialize the hooks and ended up hitting an assert in debug mode. BUG= R=johnmccutchan@google.com, zra@google.com Committed: https://github.com/dart-lang/sdk/commit/3a1b7bdfcaa9374f76807062914ebae29d389408

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M runtime/vm/malloc_hooks.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
bkonyi
3 years, 10 months ago (2017-02-24 22:54:58 UTC) #2
Cutch
lgtm
3 years, 10 months ago (2017-02-24 22:57:06 UTC) #3
zra
lgtm
3 years, 10 months ago (2017-02-24 22:58:00 UTC) #4
bkonyi
3 years, 10 months ago (2017-02-24 22:58:50 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
3a1b7bdfcaa9374f76807062914ebae29d389408 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698