Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Side by Side Diff: sdk/lib/svg/dart2js/svg_dart2js.dart

Issue 2718713003: Redo "Refined types for most HtmlElement factory constructors" (Closed)
Patch Set: ShadowElement() is unreliable Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « sdk/lib/html/dartium/html_dartium.dart ('k') | sdk/lib/svg/dartium/svg_dartium.dart » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /** 1 /**
2 * Scalable Vector Graphics: 2 * Scalable Vector Graphics:
3 * Two-dimensional vector graphics with support for events and animation. 3 * Two-dimensional vector graphics with support for events and animation.
4 * 4 *
5 * For details about the features and syntax of SVG, a W3C standard, 5 * For details about the features and syntax of SVG, a W3C standard,
6 * refer to the 6 * refer to the
7 * [Scalable Vector Graphics Specification](http://www.w3.org/TR/SVG/). 7 * [Scalable Vector Graphics Specification](http://www.w3.org/TR/SVG/).
8 */ 8 */
9 library dart.dom.svg; 9 library dart.dom.svg;
10 10
(...skipping 4704 matching lines...) Expand 10 before | Expand all | Expand 10 after
4715 4715
4716 List<Element> get children => new FilteredElementList(this); 4716 List<Element> get children => new FilteredElementList(this);
4717 4717
4718 set children(List<Element> value) { 4718 set children(List<Element> value) {
4719 final children = this.children; 4719 final children = this.children;
4720 children.clear(); 4720 children.clear();
4721 children.addAll(value); 4721 children.addAll(value);
4722 } 4722 }
4723 4723
4724 String get outerHtml { 4724 String get outerHtml {
4725 final container = new Element.tag("div"); 4725 final container = new DivElement();
4726 final SvgElement cloned = this.clone(true); 4726 final SvgElement cloned = this.clone(true);
4727 container.children.add(cloned); 4727 container.children.add(cloned);
4728 return container.innerHtml; 4728 return container.innerHtml;
4729 } 4729 }
4730 4730
4731 String get innerHtml { 4731 String get innerHtml {
4732 final container = new Element.tag("div"); 4732 final container = new DivElement();
4733 final SvgElement cloned = this.clone(true); 4733 final SvgElement cloned = this.clone(true);
4734 container.children.addAll(cloned.children); 4734 container.children.addAll(cloned.children);
4735 return container.innerHtml; 4735 return container.innerHtml;
4736 } 4736 }
4737 4737
4738 set innerHtml(String value) { 4738 set innerHtml(String value) {
4739 this.setInnerHtml(value); 4739 this.setInnerHtml(value);
4740 } 4740 }
4741 4741
4742 DocumentFragment createFragment(String svg, 4742 DocumentFragment createFragment(String svg,
(...skipping 1707 matching lines...) Expand 10 before | Expand all | Expand 10 after
6450 * Constructor instantiated by the DOM when a custom element has been created. 6450 * Constructor instantiated by the DOM when a custom element has been created.
6451 * 6451 *
6452 * This can only be called by subclasses from their created constructor. 6452 * This can only be called by subclasses from their created constructor.
6453 */ 6453 */
6454 _SVGMPathElement.created() : super.created(); 6454 _SVGMPathElement.created() : super.created();
6455 6455
6456 // From SVGURIReference 6456 // From SVGURIReference
6457 6457
6458 } 6458 }
6459 6459
OLDNEW
« no previous file with comments | « sdk/lib/html/dartium/html_dartium.dart ('k') | sdk/lib/svg/dartium/svg_dartium.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698