Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(943)

Unified Diff: runtime/bin/socket_patch.dart

Issue 2718673002: Fix issues in dart:io implementation found by fasta. (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/bin/socket_patch.dart
diff --git a/runtime/bin/socket_patch.dart b/runtime/bin/socket_patch.dart
index 3b81e083035b4d47910ce364e5e809bec37c7089..db194b9ffb6a8fe723ddd67564406fdb61f7f9b3 100644
--- a/runtime/bin/socket_patch.dart
+++ b/runtime/bin/socket_patch.dart
@@ -335,8 +335,6 @@ class _NativeSocket extends _NativeSocketNativeWrapper with _ServiceObject {
// a HttpServer, a WebSocket connection, a process pipe, etc.
Object owner;
- static double get timestamp => sw.elapsedMicroseconds / 1000000.0;
-
static Future<List<InternetAddress>> lookup(
String host, {InternetAddressType type: InternetAddressType.ANY}) {
return _IOService._dispatch(_SOCKET_LOOKUP, [host, type._value])
@@ -403,7 +401,7 @@ class _NativeSocket extends _NativeSocketNativeWrapper with _ServiceObject {
return lookup(host)
.then((addresses) {
if (addresses.isEmpty) {
- throw createError(response, "Failed host lookup: '$host'");
+ throw createError(null, "Failed host lookup: '$host'");
}
return addresses;
});
@@ -505,7 +503,7 @@ class _NativeSocket extends _NativeSocketNativeWrapper with _ServiceObject {
return lookup(host)
.then((list) {
if (list.length == 0) {
- throw createError(response, "Failed host lookup: '$host'");
+ throw createError(null, "Failed host lookup: '$host'");
}
return list[0];
});
@@ -544,7 +542,7 @@ class _NativeSocket extends _NativeSocketNativeWrapper with _ServiceObject {
return lookup(host)
.then((list) {
if (list.length == 0) {
- throw createError(response, "Failed host lookup: '$host'");
+ throw createError(null, "Failed host lookup: '$host'");
}
return list[0];
});
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698