Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Issue 2718673002: Fix issues in dart:io implementation found by fasta. (Closed)

Created:
3 years, 10 months ago by Vyacheslav Egorov (Google)
Modified:
3 years, 10 months ago
Reviewers:
kustermann
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix issues in dart:io implementation found by fasta. R=kustermann@google.com BUG=https://github.com/dart-lang/sdk/issues/28882 Committed: https://github.com/dart-lang/sdk/commit/f746f278708544c5851ca3f21a2bf49d892e8bb0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -5 lines) Patch
M runtime/bin/socket_patch.dart View 4 chunks +3 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Vyacheslav Egorov (Google)
3 years, 10 months ago (2017-02-24 11:15:25 UTC) #1
kustermann
LGTM
3 years, 10 months ago (2017-02-24 11:17:07 UTC) #3
Vyacheslav Egorov (Google)
3 years, 10 months ago (2017-02-24 11:19:59 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
f746f278708544c5851ca3f21a2bf49d892e8bb0 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698