Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(273)

Unified Diff: sdk/lib/async/future.dart

Issue 2718643003: fix future onError handler wrapping to avoid cast error (Closed)
Patch Set: add todo Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | sdk/lib/async/future_impl.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/async/future.dart
diff --git a/sdk/lib/async/future.dart b/sdk/lib/async/future.dart
index 5b570c606f6869df24fbe6a621772e8f32634bf5..355cd4c7606113807c63de5e303ed05cb1652294 100644
--- a/sdk/lib/async/future.dart
+++ b/sdk/lib/async/future.dart
@@ -304,7 +304,9 @@ abstract class Future<T> {
StackTrace stackTrace; // The stackTrace that came with the error.
// Handle an error from any of the futures.
- void handleError(theError, theStackTrace) {
+ // TODO(jmesserly): use `void` return type once it can be inferred for the
+ // `then` call below.
+ handleError(theError, theStackTrace) {
remaining--;
if (values != null) {
if (cleanUp != null) {
« no previous file with comments | « no previous file | sdk/lib/async/future_impl.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698