Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Unified Diff: sdk/lib/async/stream_impl.dart

Issue 2718643003: fix future onError handler wrapping to avoid cast error (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« sdk/lib/async/future_impl.dart ('K') | « sdk/lib/async/future_impl.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/async/stream_impl.dart
diff --git a/sdk/lib/async/stream_impl.dart b/sdk/lib/async/stream_impl.dart
index 29cfbd1c3ce5cc1055f0f5240734352e7be9b7d3..9cecbb0009fdb2b0f211ad2eb0d214c54c617d6c 100644
--- a/sdk/lib/async/stream_impl.dart
+++ b/sdk/lib/async/stream_impl.dart
@@ -144,9 +144,7 @@ class _BufferingStreamSubscription<T> implements StreamSubscription<T>,
void onError(Function handleError) {
if (handleError == null) handleError = _nullErrorHandler;
- // We are not allowed to use 'void' as type argument for the generic type,
- // so we use 'dynamic' instead.
- _onError = _registerErrorHandler<dynamic>(handleError, _zone);
+ _onError = _registerErrorHandler(handleError, _zone);
}
void onDone(void handleDone()) {
« sdk/lib/async/future_impl.dart ('K') | « sdk/lib/async/future_impl.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698