Fix gesture event handling in MenuButton

Fix gesture event handling in MenuButton

In MenuButton, when Activate() function returns true, it means the
button has not shown a drop-down menu, so the gesture event handler
should continue handling the event passing it up to the base class
handler. On the other hand, if it returns false, the drop-down menu is
shown and no more processing is needed by the button.
Also, touch_down_context_ in HWNDMessageHandler is changed from boolean
to integer in order to account for multiple touches happening right
after each other.

BUG=349881
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270756

[mohsen, 2014-05-08 21:18:22]

sky@: Please take a look...
ananta@: Can you take a look at changes in HWNDMessageHandler?

[sky, 2014-05-08 23:09:49]

I suspect your test isn't going to work on windows. Have you tried it?

[mohsen, 2014-05-08 23:16:57]

On 2014/05/08 23:09:49, sky wrote:
> I suspect your test isn't going to work on windows. Have you tried it?

Yes. I mainly developed this CL on Windows. Which part do you think is not
Windows-friendly?

[sky, 2014-05-08 23:33:25]

I'm worried about focus activation and all sort of stuff like that as
you're creating a top level widget. But as you're using EventGenerator
maybe that is ok?

On Thu, May 8, 2014 at 4:16 PM,  <mohsen@chromium.org> wrote:
> On 2014/05/08 23:09:49, sky wrote:
>>
>> I suspect your test isn't going to work on windows. Have you tried it?
>
>
> Yes. I mainly developed this CL on Windows. Which part do you think is not
> Windows-friendly?
>
> https://codereview.chromium.org/271863006/

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[mohsen, 2014-05-09 00:07:02]

I don't think there is any focus/activation problem here. I'm using an event
generator which dispatches events directly to the menu button, and the menu
button just calls callbacks on mock listeners provided to it (For example it
does not create any menus. That's the callbacks responsibility to create a menu
which my callback functions don't).

On 2014/05/08 23:33:25, sky wrote:
> I'm worried about focus activation and all sort of stuff like that as
> you're creating a top level widget. But as you're using EventGenerator
> maybe that is ok?
> 
> On Thu, May 8, 2014 at 4:16 PM,  <mailto:mohsen@chromium.org> wrote:
> > On 2014/05/08 23:09:49, sky wrote:
> >>
> >> I suspect your test isn't going to work on windows. Have you tried it?
> >
> >
> > Yes. I mainly developed this CL on Windows. Which part do you think is not
> > Windows-friendly?
> >
> > https://codereview.chromium.org/271863006/
> 
> To unsubscribe from this group and stop receiving emails from it, send an
email
> to mailto:chromium-reviews+unsubscribe@chromium.org.

[sky, 2014-05-09 13:55:20]

LGTM

[ananta, 2014-05-15 17:20:07]

lgtm

[mohsen, 2014-05-15 17:33:48]

The CQ bit was checked by mohsen@chromium.org

[commit-bot: I haz the power, 2014-05-15 17:36:00]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/mohsen@chromium.org/271863006/20001

[commit-bot: I haz the power, 2014-05-15 18:51:37]

Change committed as 270756