Added shorcut:"F11" for exit fullscreen context menu.

Added shorcut:"F11" for exit fullscreen context menu.

We should display F11 shorcut for the exit fullscreen
context menu, when the full screen is not site-triggered.

BUG=674108
Signed-off-by: kumar.vikram <kumar.vikram@samsung.com>;

[kumar.vikram, 2017-02-24 13:17:14]

Description was changed from

==========
Added code for !IsHTML5Fullscreen() F12 key

We should use F11 key for !IsHTML5Fullscreen()
instead of escape key.

BUG=674108

Signed-off-by: kumar.vikram <kumar.vikram@samsung.com>
==========

to

==========
Added code for !IsHTML5Fullscreen() F12 key

We should use F11 key for cases which are not site triggered
instead of escape key.

BUG=674108

Signed-off-by: kumar.vikram <kumar.vikram@samsung.com>
==========

[kumar.vikram, 2017-02-24 13:17:14]

kumar.vikram@samsung.com changed reviewers:
+ a.suchit@chromium.org, a.suchit@samsung.com

[kumar.vikram, 2017-02-24 13:21:03]

kumar.vikram@samsung.com changed reviewers:
+ dsinclair@chromium.org, raymes@chromium.org

[kumar.vikram, 2017-02-24 13:21:50]

Description was changed from

==========
Added code for !IsHTML5Fullscreen() F12 key

We should use F11 key for cases which are not site triggered
instead of escape key.

BUG=674108

Signed-off-by: kumar.vikram <kumar.vikram@samsung.com>
==========

to

==========
Added code for !IsHTML5Fullscreen() F11 key

We should use F11 key for cases which are not site triggered
instead of escape key.

BUG=674108

Signed-off-by: kumar.vikram <kumar.vikram@samsung.com>
==========

[Srirama, 2017-02-27 06:25:15]

srirama.m@samsung.com changed reviewers:
+ srirama.m@samsung.com

[Srirama, 2017-02-27 06:25:16]

https://codereview.chromium.org/2718623004/diff/1/chrome/browser/ui/views/ren...
File
chrome/browser/ui/views/renderer_context_menu/render_view_context_menu_views.cc
(right):

https://codereview.chromium.org/2718623004/diff/1/chrome/browser/ui/views/ren...
chrome/browser/ui/views/renderer_context_menu/render_view_context_menu_views.cc:141:
else {
nit: move else to previous line. Other than this, changes looks fine to me.

[kumar.vikram, 2017-02-27 06:53:45]

On 2017/02/27 06:25:16, Srirama wrote:
>
https://codereview.chromium.org/2718623004/diff/1/chrome/browser/ui/views/ren...
> File
>
chrome/browser/ui/views/renderer_context_menu/render_view_context_menu_views.cc
> (right):
> 
>
https://codereview.chromium.org/2718623004/diff/1/chrome/browser/ui/views/ren...
>
chrome/browser/ui/views/renderer_context_menu/render_view_context_menu_views.cc:141:
> else {
> nit: move else to previous line. Other than this, changes looks fine to me.

done

[kumar.vikram, 2017-02-27 06:55:11]

Description was changed from

==========
Added code for !IsHTML5Fullscreen() F11 key

We should use F11 key for cases which are not site triggered
instead of escape key.

BUG=674108

Signed-off-by: kumar.vikram <kumar.vikram@samsung.com>
==========

to

==========
Added shorcut:"F11" for exit fullscreen context menu.

We should display F11 shorcut for the exit fullscreen
context menu, when the full screen is not site-triggered..

BUG=674108

Signed-off-by: kumar.vikram <kumar.vikram@samsung.com>
==========

[kumar.vikram, 2017-02-27 06:56:32]

Description was changed from

==========
Added shorcut:"F11" for exit fullscreen context menu.

We should display F11 shorcut for the exit fullscreen
context menu, when the full screen is not site-triggered..

BUG=674108

Signed-off-by: kumar.vikram <kumar.vikram@samsung.com>
==========

to

==========
Added shorcut:"F11" for exit fullscreen context menu.

We should display F11 shorcut for the exit fullscreen
context menu, when the full screen is not site-triggered.

BUG=674108

Signed-off-by: kumar.vikram <kumar.vikram@samsung.com>
==========

[dsinclair, 2017-02-27 14:16:42]

dsinclair@chromium.org changed reviewers:
+ thestig@chromium.org

[Lei Zhang, 2017-02-27 19:43:35]

I'm not 100% sure this is the right place to add the new code. I will take a
look at this CL in the near future.

[Lei Zhang, 2017-02-28 04:17:35]

https://codereview.chromium.org/2718623004/diff/40001/chrome/browser/ui/views...
File
chrome/browser/ui/views/renderer_context_menu/render_view_context_menu_views.cc
(right):

https://codereview.chromium.org/2718623004/diff/40001/chrome/browser/ui/views...
chrome/browser/ui/views/renderer_context_menu/render_view_context_menu_views.cc:141:
*accel = ui::Accelerator(ui::VKEY_F11, ui::EF_NONE);
I don't know what the right answer is, but this isn't it. See the ChromeOS code
right below here. We don't want to show F11 on ChromeOS.

[Lei Zhang, 2017-02-28 05:06:26]

On 2017/02/28 04:17:35, Lei Zhang (super slow) wrote:
>
https://codereview.chromium.org/2718623004/diff/40001/chrome/browser/ui/views...
> File
>
chrome/browser/ui/views/renderer_context_menu/render_view_context_menu_views.cc
> (right):
> 
>
https://codereview.chromium.org/2718623004/diff/40001/chrome/browser/ui/views...
>
chrome/browser/ui/views/renderer_context_menu/render_view_context_menu_views.cc:141:
> *accel = ui::Accelerator(ui::VKEY_F11, ui::EF_NONE);
> I don't know what the right answer is, but this isn't it. See the ChromeOS
code
> right below here. We don't want to show F11 on ChromeOS.

And so I looked and came up with https://codereview.chromium.org/2720963002/

[dsinclair, 2017-03-07 16:05:44]

dsinclair@chromium.org changed reviewers:
- dsinclair@chromium.org