Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(418)

Issue 2718623002: DevTools: remove selections on dropdown menu open

Created:
3 years, 10 months ago by luoe
Modified:
3 years, 7 months ago
Reviewers:
einbinder
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: remove selections on dropdown menu open Operating systems have native behavior to add items to context menus such as 'Copy' when selecting text. Opening a dropdown menu does not carry the same intent, so removing prior selections avoids unnecessary items. Some items including 'Add to iTunes as spoken track' remember the last selection and are unavoidable without altering system preferences. BUG=687466

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M third_party/WebKit/Source/devtools/front_end/ui/DropDownMenu.js View 1 chunk +5 lines, -0 lines 1 comment Download

Messages

Total messages: 8 (4 generated)
luoe
ptal
3 years, 10 months ago (2017-02-24 07:46:01 UTC) #2
luoe
For reference, DropdownMenus are used in the '>>' menu in a TabbedPane. Regular context menus ...
3 years, 9 months ago (2017-02-27 19:00:00 UTC) #5
lushnikov
https://codereview.chromium.org/2718623002/diff/1/third_party/WebKit/Source/devtools/front_end/ui/DropDownMenu.js File third_party/WebKit/Source/devtools/front_end/ui/DropDownMenu.js (right): https://codereview.chromium.org/2718623002/diff/1/third_party/WebKit/Source/devtools/front_end/ui/DropDownMenu.js#newcode27 third_party/WebKit/Source/devtools/front_end/ui/DropDownMenu.js:27: var selection = UI.inspectorView.element.window().getSelection(); it would be nice if ...
3 years, 9 months ago (2017-03-03 04:11:00 UTC) #6
einbinder
3 years, 9 months ago (2017-03-09 09:35:12 UTC) #7
lgtm

Powered by Google App Engine
This is Rietveld 408576698