third_party/WebKit/LayoutTests/bluetooth/server/connect/same-gatt-server-both-receive-disconnect-event.html - Issue 2718583002: Refactor WebBluetoothServiceClient in the web_bluetooth.mojom

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/bluetooth/server/connect/same-gatt-server-both-receive-disconnect-event.html

Issue 2718583002: Refactor WebBluetoothServiceClient in the web_bluetooth.mojom (Closed)

Patch Set: address comments Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« third_party/WebKit/LayoutTests/bluetooth/server/connect/connect-twice.html ('K') | « third_party/WebKit/LayoutTests/bluetooth/server/connect/connect-twice.html ('k') | third_party/WebKit/Source/modules/bluetooth/Bluetooth.h » ('j') | third_party/WebKit/Source/modules/bluetooth/BluetoothDevice.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <script src="../../../resources/testharness.js"></script>

	3 <script src="../../../resources/testharnessreport.js"></script>

	4 <script src="../../../resources/bluetooth/bluetooth-helpers.js"></script>

	5 <script>

	6 'use strict';

	7 var device;

	8 promise_test(() => {

	9 return setBluetoothFakeAdapter('DisconnectingHeartRateAdapter')
	ortuno 2017/03/01 04:52:06 DisconnectingHealthThermometer please. DisconnectingHealthThermometer please. juncai 2017/03/02 03:23:46 Done. Show quoted text On 2017/03/01 04:52:06, ortuno wrote: > DisconnectingHealthThermometer please. Done.
	10 .then(() => requestDeviceWithKeyDown({

	11 filters: [{services: ['heart_rate']}],

	12 optionalServices: [request_disconnection_service_uuid]

	13 }))

	14 .then(requestedDevice => {

	15 device = requestedDevice;

	16 return Promise.all([device.gatt.connect(), device.gatt.connect()]);

	17 }).then(gattServers => {

	18 return Promise.all([get_request_disconnection(gattServers[0]), get_request _disconnection(gattServers[1])]);
	ortuno 2017/03/01 04:52:06 No need to get two requests or the bubbles check: No need to get two requests or the bubbles check: }) .then([gattServer,] => get_request_disconnection(gattServer)) .then(requestDisconnection => { let disconnected = eventPromise(device, 'gattserverdisconnected'); return Promise.all([requestDisconnection(), disconnected]); }); juncai 2017/03/02 03:23:45 Done. Show quoted text On 2017/03/01 04:52:06, ortuno wrote: > No need to get two requests or the bubbles check: > > }) > .then([gattServer,] => get_request_disconnection(gattServer)) > .then(requestDisconnection => { > let disconnected = eventPromise(device, 'gattserverdisconnected'); > return Promise.all([requestDisconnection(), disconnected]); > }); Done.
	19 }).then(requestDisconnection => {

	20 // This promise hangs unless gattserverdisconnected is fired.

	21 let disconnected = eventPromise(device, 'gattserverdisconnected');

	22 return Promise.all([requestDisconnection[0](), requestDisconnection[1] (),

	23 disconnected]);

	24 }).then(([, , disconnected]) => assert_true(disconnected.bubbles));

	25 }, 'Same gatt server should both receive disconnect event.');
	ortuno 2017/03/01 04:52:05 A device disconnecting after two consecutive conne A device disconnecting after two consecutive connect requests should fire an event. juncai 2017/03/02 03:23:44 Done. Show quoted text On 2017/03/01 04:52:05, ortuno wrote: > A device disconnecting after two consecutive connect requests should fire an > event. Done.
	26 </script>

OLD	NEW