third_party/WebKit/LayoutTests/bluetooth/server/connect/connect-twice.html - Issue 2718583002: Refactor WebBluetoothServiceClient in the web_bluetooth.mojom

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/bluetooth/server/connect/connect-twice.html

Issue 2718583002: Refactor WebBluetoothServiceClient in the web_bluetooth.mojom (Closed)

Patch Set: address comments Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <script src="../../../resources/testharness.js"></script>

	3 <script src="../../../resources/testharnessreport.js"></script>

	4 <script src="../../../resources/bluetooth/bluetooth-helpers.js"></script>

	5 <script>

	6 'use strict';

	7 promise_test(t => {

	8 return setBluetoothFakeAdapter('DisconnectingHeartRateAdapter')
	ortuno 2017/03/01 04:52:05 nit: Can you change this to DisconnectingHealthThe nit: Can you change this to DisconnectingHealthThermometerAdapter? We are trying to move away from HeartRate. juncai 2017/03/02 03:23:43 Done. Show quoted text On 2017/03/01 04:52:05, ortuno wrote: > nit: Can you change this to DisconnectingHealthThermometerAdapter? We are trying > to move away from HeartRate. Done.
	9 .then(() => requestDeviceWithKeyDown({

	10 filters: [{services: ['heart_rate']}],

	11 optionalServices: [request_disconnection_service_uuid]

	12 }))

	13 .then(device => {

	14 return device.gatt.connect()

	15 .then(gattServer => gattServer.connect())

	16 .then(gattServer => get_request_disconnection(gattServer))

	17 .then(requestDisconnection => {

	18 // This promise hangs unless gattserverdisconnected is fired.

	19 let disconnected = eventPromise(device, 'gattserverdisconnected');

	20 return Promise.all([requestDisconnection(),

	21 disconnected]);

	22 }).then(([, disconnected]) => assert_true(disconnected.bubbles));

	23 });

	24 }, 'A device disconnecting after connected twice should fire the gattserverdisc onnected event.');

	25 </script>

OLD	NEW