Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Unified Diff: chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl.h

Issue 2718563008: mash: Use mojo for ShelfItemDelegate and [app] MenuItem. (Closed)
Patch Set: Address comments. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl.h
diff --git a/chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl.h b/chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl.h
index 037a222158609db06ef4b07d86b80c8cd2e2ecce..31d6d6fc0fae596255cde9e3961d10d3748086dc 100644
--- a/chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl.h
+++ b/chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl.h
@@ -95,8 +95,7 @@ class ChromeLauncherControllerImpl
bool allow_minimize) override;
void ActiveUserChanged(const std::string& user_email) override;
void AdditionalUserAddedToSession(Profile* profile) override;
- ash::ShelfAppMenuItemList GetAppMenuItemsForTesting(
- const ash::ShelfItem& item) override;
+ MenuItemList GetAppMenuItemsForTesting(const ash::ShelfItem& item) override;
std::vector<content::WebContents*> GetV1ApplicationsFromAppId(
const std::string& app_id) override;
void ActivateShellApp(const std::string& app_id, int window_index) override;
@@ -244,7 +243,7 @@ class ChromeLauncherControllerImpl
// Set ShelfItemDelegate |item_delegate| for |id| and take an ownership.
// TODO(simon.hong81): Make this take a scoped_ptr of |item_delegate|.
void SetShelfItemDelegate(ash::ShelfID id,
- ash::ShelfItemDelegate* item_delegate);
+ ash::mojom::ShelfItemDelegate* item_delegate);
// Forget the current profile to allow attaching to a new one.
void ReleaseProfile();
@@ -254,8 +253,9 @@ class ChromeLauncherControllerImpl
void ShelfItemRemoved(int index, ash::ShelfID id) override;
void ShelfItemMoved(int start_index, int target_index) override;
void ShelfItemChanged(int index, const ash::ShelfItem& old_item) override;
- void OnSetShelfItemDelegate(ash::ShelfID id,
- ash::ShelfItemDelegate* item_delegate) override;
+ void OnSetShelfItemDelegate(
+ ash::ShelfID id,
+ ash::mojom::ShelfItemDelegate* item_delegate) override;
// ash::WindowTreeHostManager::Observer:
void OnDisplayConfigurationChanged() override;

Powered by Google App Engine
This is Rietveld 408576698