chrome/browser/ui/ash/launcher/extension_app_window_launcher_item_controller.h - Issue 2718563008: mash: Use mojo for ShelfItemDelegate and [app] MenuItem.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/ash/launcher/extension_app_window_launcher_item_controller.h

Issue 2718563008: mash: Use mojo for ShelfItemDelegate and [app] MenuItem. (Closed)

Patch Set: Address comments. Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/ash/launcher/app_shortcut_launcher_item_controller.cc ('K') | « chrome/browser/ui/ash/launcher/chrome_launcher_controller_mus.cc ('k') | chrome/browser/ui/ash/launcher/extension_app_window_launcher_item_controller.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/ash/launcher/extension_app_window_launcher_item_controller.h

diff --git a/chrome/browser/ui/ash/launcher/extension_app_window_launcher_item_controller.h b/chrome/browser/ui/ash/launcher/extension_app_window_launcher_item_controller.h

index c8085f15cafc035358a34a034eea3ae2aec907c6..17f111d69c990913ebd85d2bfa5730ef8bb1fac6 100644

--- a/chrome/browser/ui/ash/launcher/extension_app_window_launcher_item_controller.h

+++ b/chrome/browser/ui/ash/launcher/extension_app_window_launcher_item_controller.h

@@ -30,8 +30,9 @@ class ExtensionAppWindowLauncherItemController

void AddAppWindow(extensions::AppWindow* app_window);

// AppWindowLauncherItemController:

- ash::ShelfAppMenuItemList GetAppMenuItems(int event_flags) override;

- void ExecuteCommand(uint32_t command_id, int event_flags) override;

+ std::vector<ash::mojom::MenuItemPtr> GetAppMenuItems(

+ int event_flags) override;

+ void ExecuteCommand(uint32_t command_id, int32_t event_flags) override;

private:

DISALLOW_COPY_AND_ASSIGN(ExtensionAppWindowLauncherItemController);