Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2350)

Unified Diff: ash/common/shelf/shelf_application_menu_model.h

Issue 2718563008: mash: Use mojo for ShelfItemDelegate and [app] MenuItem. (Closed)
Patch Set: Cleanup; fix ash_shell compile and a couple tests. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ash/common/shelf/shelf_application_menu_model.h
diff --git a/ash/common/shelf/shelf_application_menu_model.h b/ash/common/shelf/shelf_application_menu_model.h
index 7abe8b54e247b73c86f752a0f05295dae64415d8..af97218b395cafe4e5d39a9c99e52b7d82e43a20 100644
--- a/ash/common/shelf/shelf_application_menu_model.h
+++ b/ash/common/shelf/shelf_application_menu_model.h
@@ -9,7 +9,7 @@
#include <vector>
#include "ash/ash_export.h"
-#include "ash/public/cpp/shelf_application_menu_item.h"
+#include "ash/common/shelf/shelf_item_delegate.h"
#include "base/macros.h"
#include "ui/base/models/simple_menu_model.h"
@@ -21,10 +21,10 @@ class ShelfItemDelegate;
// A menu model listing open applications associated with a shelf item. Layout:
// +---------------------------+
// | |
-// | App Title |
+// | Shelf Item Title |
// | |
-// | [Icon] Item Title |
-// | [Icon] Item Title |
+// | [Icon] Menu Item Label |
+// | [Icon] Menu Item Label |
// | |
// +---------------------------+
class ASH_EXPORT ShelfApplicationMenuModel
@@ -34,7 +34,7 @@ class ASH_EXPORT ShelfApplicationMenuModel
// Makes a menu with a |title|, separators, and |items| for |delegate|.
// |delegate| may be null in unit tests that do not execute commands.
ShelfApplicationMenuModel(const base::string16& title,
- ShelfAppMenuItemList items,
+ ShelfItemDelegate::MenuItemList items,
ShelfItemDelegate* delegate);
~ShelfApplicationMenuModel() override;
@@ -51,7 +51,7 @@ class ASH_EXPORT ShelfApplicationMenuModel
int num_menu_items_enabled);
// The list of menu items as returned from the shelf item's controller.
- ShelfAppMenuItemList items_;
+ ShelfItemDelegate::MenuItemList items_;
// The shelf item delegate that created the menu and executes its commands.
ShelfItemDelegate* delegate_;

Powered by Google App Engine
This is Rietveld 408576698