Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1087)

Side by Side Diff: ash/common/shelf/shelf_model_observer.h

Issue 2718563008: mash: Use mojo for ShelfItemDelegate and [app] MenuItem. (Closed)
Patch Set: Address comments. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef ASH_COMMON_SHELF_SHELF_MODEL_OBSERVER_H_ 5 #ifndef ASH_COMMON_SHELF_SHELF_MODEL_OBSERVER_H_
6 #define ASH_COMMON_SHELF_SHELF_MODEL_OBSERVER_H_ 6 #define ASH_COMMON_SHELF_SHELF_MODEL_OBSERVER_H_
7 7
8 #include "ash/ash_export.h" 8 #include "ash/ash_export.h"
9 #include "ash/common/shelf/shelf_item_types.h" 9 #include "ash/common/shelf/shelf_item_types.h"
10 10
11 namespace ash { 11 namespace ash {
12 12
13 struct ShelfItem; 13 struct ShelfItem;
14
15 namespace mojom {
14 class ShelfItemDelegate; 16 class ShelfItemDelegate;
17 }
15 18
16 class ASH_EXPORT ShelfModelObserver { 19 class ASH_EXPORT ShelfModelObserver {
17 public: 20 public:
18 // Invoked after an item has been added to the model. 21 // Invoked after an item has been added to the model.
19 virtual void ShelfItemAdded(int index) = 0; 22 virtual void ShelfItemAdded(int index) = 0;
20 23
21 // Invoked after an item has been removed. |index| is the index the item was 24 // Invoked after an item has been removed. |index| is the index the item was
22 // at. 25 // at.
23 virtual void ShelfItemRemoved(int index, ShelfID id) = 0; 26 virtual void ShelfItemRemoved(int index, ShelfID id) = 0;
24 27
25 // Invoked after an item has been moved. See ShelfModel::Move() for details 28 // Invoked after an item has been moved. See ShelfModel::Move() for details
26 // of the arguments. 29 // of the arguments.
27 virtual void ShelfItemMoved(int start_index, int target_index) = 0; 30 virtual void ShelfItemMoved(int start_index, int target_index) = 0;
28 31
29 // Invoked when the state of an item changes. |old_item| is the item 32 // Invoked when the state of an item changes. |old_item| is the item
30 // before the change. 33 // before the change.
31 virtual void ShelfItemChanged(int index, const ShelfItem& old_item) = 0; 34 virtual void ShelfItemChanged(int index, const ShelfItem& old_item) = 0;
32 35
33 // Gets called when a ShelfItemDelegate gets changed. Note that 36 // Gets called when a ShelfItemDelegate gets changed. Note that
34 // |item_delegate| can be null. 37 // |item_delegate| can be null.
35 // NOTE: This is added a temporary fix for M39 to fix crbug.com/429870. 38 // NOTE: This is added a temporary fix for M39 to fix crbug.com/429870.
36 // TODO(skuhne): Find the real reason for this problem and remove this fix. 39 // TODO(skuhne): Find the real reason for this problem and remove this fix.
37 virtual void OnSetShelfItemDelegate(ShelfID id, 40 virtual void OnSetShelfItemDelegate(
38 ShelfItemDelegate* item_delegate) = 0; 41 ShelfID id,
42 mojom::ShelfItemDelegate* item_delegate) = 0;
39 43
40 protected: 44 protected:
41 virtual ~ShelfModelObserver() {} 45 virtual ~ShelfModelObserver() {}
42 }; 46 };
43 47
44 } // namespace ash 48 } // namespace ash
45 49
46 #endif // ASH_COMMON_SHELF_SHELF_MODEL_OBSERVER_H_ 50 #endif // ASH_COMMON_SHELF_SHELF_MODEL_OBSERVER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698