Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(599)

Side by Side Diff: ash/common/shelf/shelf_application_menu_model.h

Issue 2718563008: mash: Use mojo for ShelfItemDelegate and [app] MenuItem. (Closed)
Patch Set: Address comments. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2017 The Chromium Authors. All rights reserved. 1 // Copyright 2017 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef ASH_COMMON_SHELF_SHELF_APPLICATION_MENU_MODEL_H_ 5 #ifndef ASH_COMMON_SHELF_SHELF_APPLICATION_MENU_MODEL_H_
6 #define ASH_COMMON_SHELF_SHELF_APPLICATION_MENU_MODEL_H_ 6 #define ASH_COMMON_SHELF_SHELF_APPLICATION_MENU_MODEL_H_
7 7
8 #include <memory> 8 #include <memory>
9 #include <vector> 9 #include <vector>
10 10
11 #include "ash/ash_export.h" 11 #include "ash/ash_export.h"
12 #include "ash/public/cpp/shelf_application_menu_item.h" 12 #include "ash/public/interfaces/shelf.mojom.h"
13 #include "base/macros.h" 13 #include "base/macros.h"
14 #include "ui/base/models/simple_menu_model.h" 14 #include "ui/base/models/simple_menu_model.h"
15 15
16 namespace ash { 16 namespace ash {
17 17
18 class ShelfApplicationMenuModelTestAPI; 18 class ShelfApplicationMenuModelTestAPI;
19 class ShelfItemDelegate;
20 19
21 // A menu model listing open applications associated with a shelf item. Layout: 20 // A menu model listing open applications associated with a shelf item. Layout:
22 // +---------------------------+ 21 // +---------------------------+
23 // | | 22 // | |
24 // | App Title | 23 // | Shelf Item Title |
25 // | | 24 // | |
26 // | [Icon] Item Title | 25 // | [Icon] Menu Item Label |
27 // | [Icon] Item Title | 26 // | [Icon] Menu Item Label |
28 // | | 27 // | |
29 // +---------------------------+ 28 // +---------------------------+
30 class ASH_EXPORT ShelfApplicationMenuModel 29 class ASH_EXPORT ShelfApplicationMenuModel
31 : public ui::SimpleMenuModel, 30 : public ui::SimpleMenuModel,
32 public ui::SimpleMenuModel::Delegate { 31 public ui::SimpleMenuModel::Delegate {
33 public: 32 public:
34 // Makes a menu with a |title|, separators, and |items| for |delegate|. 33 // Makes a menu with a |title|, separators, and |items| for |delegate|.
35 // |delegate| may be null in unit tests that do not execute commands. 34 // |delegate| may be null in unit tests that do not execute commands.
36 ShelfApplicationMenuModel(const base::string16& title, 35 ShelfApplicationMenuModel(const base::string16& title,
37 ShelfAppMenuItemList items, 36 std::vector<mojom::MenuItemPtr> items,
38 ShelfItemDelegate* delegate); 37 mojom::ShelfItemDelegate* delegate);
39 ~ShelfApplicationMenuModel() override; 38 ~ShelfApplicationMenuModel() override;
40 39
41 // ui::SimpleMenuModel::Delegate: 40 // ui::SimpleMenuModel::Delegate:
42 bool IsCommandIdChecked(int command_id) const override; 41 bool IsCommandIdChecked(int command_id) const override;
43 bool IsCommandIdEnabled(int command_id) const override; 42 bool IsCommandIdEnabled(int command_id) const override;
44 void ExecuteCommand(int command_id, int event_flags) override; 43 void ExecuteCommand(int command_id, int event_flags) override;
45 44
46 private: 45 private:
47 friend class ShelfApplicationMenuModelTestAPI; 46 friend class ShelfApplicationMenuModelTestAPI;
48 47
49 // Records UMA metrics when a menu item is selected. 48 // Records UMA metrics when a menu item is selected.
50 void RecordMenuItemSelectedMetrics(int command_id, 49 void RecordMenuItemSelectedMetrics(int command_id,
51 int num_menu_items_enabled); 50 int num_menu_items_enabled);
52 51
53 // The list of menu items as returned from the shelf item's controller. 52 // The list of menu items as returned from the shelf item's controller.
54 ShelfAppMenuItemList items_; 53 std::vector<mojom::MenuItemPtr> items_;
55 54
56 // The shelf item delegate that created the menu and executes its commands. 55 // The shelf item delegate that created the menu and executes its commands.
57 ShelfItemDelegate* delegate_; 56 mojom::ShelfItemDelegate* delegate_;
58 57
59 DISALLOW_COPY_AND_ASSIGN(ShelfApplicationMenuModel); 58 DISALLOW_COPY_AND_ASSIGN(ShelfApplicationMenuModel);
60 }; 59 };
61 60
62 } // namespace ash 61 } // namespace ash
63 62
64 #endif // ASH_COMMON_SHELF_SHELF_APPLICATION_MENU_MODEL_H_ 63 #endif // ASH_COMMON_SHELF_SHELF_APPLICATION_MENU_MODEL_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698