mash: Use mojo for ShelfItemDelegate and [app] MenuItem.

chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_browsertest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl.h"
 
 #include <stddef.h>
 
 #include "ash/common/shelf/app_list_button.h"
 #include "ash/common/shelf/shelf_button.h"
@@ skipping 60 matching lines @@
 #include "testing/gtest/include/gtest/gtest.h"
 #include "ui/app_list/app_list_switches.h"
 #include "ui/app_list/views/app_list_item_view.h"
 #include "ui/app_list/views/apps_grid_view.h"
 #include "ui/app_list/views/start_page_view.h"
 #include "ui/app_list/views/tile_item_view.h"
 #include "ui/aura/client/aura_constants.h"
 #include "ui/aura/window.h"
 #include "ui/base/window_open_disposition.h"
 #include "ui/display/test/display_manager_test_api.h"
+#include "ui/events/base_event_utils.h"
 #include "ui/events/event.h"
 #include "ui/events/event_constants.h"
 #include "ui/events/test/event_generator.h"
 
 using ash::WmShelf;
 using extensions::AppWindow;
 using extensions::Extension;
 using content::WebContents;
 
 namespace {
 
 ChromeLauncherControllerImpl* GetChromeLauncherControllerImpl() {
   return static_cast<ChromeLauncherControllerImpl*>(
       ChromeLauncherController::instance());
 }
 
+// A callback that records the action taken when a shelf item is selected.
+void SelectItemCallback(ash::ShelfAction* action_taken,
+                        base::Closure run_loop_quit_closure,

[James Cook, 2017/03/09 01:09:47]

optional: you could also take a RunLoop* run_loop and call run_loop->Quit() to
be symmetric with ShelfAction*

[msw, 2017/03/10 06:17:57]

Done.

+                        ash::ShelfAction action,
+                        ash::ShelfItemDelegate::MenuItemList) {
+  *action_taken = action;
+  run_loop_quit_closure.Run();
+}
+
 // Calls ShelfItemDelegate::SelectItem with an event type and default arguments.
 ash::ShelfAction SelectItem(ash::ShelfItemDelegate* delegate,
                             ui::EventType event_type) {
-  return delegate->ItemSelected(event_type, ui::EF_NONE,
-                                display::kInvalidDisplayId,
-                                ash::LAUNCH_FROM_UNKNOWN);
+  std::unique_ptr<ui::Event> event;
+  if (event_type == ui::ET_MOUSE_PRESSED) {
+    event =
+        base::MakeUnique<ui::MouseEvent>(event_type, gfx::Point(), gfx::Point(),
+                                         ui::EventTimeForNow(), ui::EF_NONE, 0);
+  } else if (event_type == ui::ET_KEY_RELEASED) {
+    event = base::MakeUnique<ui::KeyEvent>(event_type, ui::VKEY_UNKNOWN,
+                                           ui::EF_NONE);
+  }
+
+  base::RunLoop run_loop;
+  ash::ShelfAction action = ash::SHELF_ACTION_NONE;
+  delegate->ItemSelected(
+      std::move(event), display::kInvalidDisplayId, ash::LAUNCH_FROM_UNKNOWN,
+      base::Bind(&SelectItemCallback, &action, run_loop.QuitClosure()));
+  run_loop.RunUntilIdle();

[James Cook, 2017/03/09 01:09:47]

Shouldn't this be run_loop.Run()?

[msw, 2017/03/10 06:17:57]

Done.

+  return action;
 }
 
 class TestEvent : public ui::Event {
  public:
   explicit TestEvent(ui::EventType type)
       : ui::Event(type, base::TimeTicks(), 0) {}
   ~TestEvent() override {}
 
  private:
   DISALLOW_COPY_AND_ASSIGN(TestEvent);
@@ skipping 2279 matching lines @@
 
   // Close all windows via the menu item.
   CloseBrowserWindow(browser(), menu1.get(), LauncherContextMenu::MENU_CLOSE);
   EXPECT_EQ(0u, BrowserList::GetInstance()->size());
 
   // Check if "Close" is removed from the context menu.
   std::unique_ptr<LauncherContextMenu> menu2 = CreateBrowserItemContextMenu();
   ASSERT_FALSE(
       IsItemPresentInMenu(menu2.get(), LauncherContextMenu::MENU_CLOSE));
 }