Chromium Code Reviews Chromium Code Reviews
Issue 2718563004:
Convert more ScriptProcessorNode tests to testharness (Closed)
| Index: third_party/WebKit/LayoutTests/webaudio/ScriptProcessor/scriptprocessornode-downmix8-2channel-input.html |
| diff --git a/third_party/WebKit/LayoutTests/webaudio/ScriptProcessor/scriptprocessornode-downmix8-2channel-input.html b/third_party/WebKit/LayoutTests/webaudio/ScriptProcessor/scriptprocessornode-downmix8-2channel-input.html |
| index cdf1127a8f0730a47addcc4b75feafa6a873c03f..8642fc25d664cd21a900b41c5cecfc07a39f3901 100644 |
| --- a/third_party/WebKit/LayoutTests/webaudio/ScriptProcessor/scriptprocessornode-downmix8-2channel-input.html |
| +++ b/third_party/WebKit/LayoutTests/webaudio/ScriptProcessor/scriptprocessornode-downmix8-2channel-input.html |
| @@ -2,37 +2,33 @@ |
| <html> |
| <head> |
| -<script src="../../resources/js-test.js"></script> |
| +<script src="../../resources/testharness.js"></script> |
| +<script src="../../resources/testharnessreport.js"></script> |
| <script src="../resources/audit-util.js"></script> |
| -<script src="../resources/audio-testing.js"></script> |
| -<script type="text/javascript" src="../resources/scriptprocessornode-testing.js"></script> |
| +<script src="../resources/audit.js"></script> |
| +<script src="../resources/scriptprocessornode-testing-audit.js"></script> |
| </head> |
| <body> |
| - |
| -<div id="description"></div> |
| -<div id="console"></div> |
| - |
| <script> |
| -description("Tests downmixing an 8-channel source connected to a JavaScriptAudioNode with 2-channel input."); |
| - |
| -var sampleRate = 44100.0; |
| -var sourceChannels = 8; |
| -var inputChannels = 2; |
| -var outputChannels = 6; |
| - |
| -function runTest() { |
| - if (window.testRunner) { |
| - testRunner.dumpAsText(); |
| - testRunner.waitUntilDone(); |
| - } |
| - |
| - window.jsTestIsAsync = true; |
| - |
| - runJSNodeTest(); |
| -} |
| - |
| -runTest(); |
| +let audit = Audit.createTaskRunner(); |
| + |
| +let sampleRate = 44100.0; |
| +let sourceChannels = 8; |
| +let inputChannels = 2; |
| +let outputChannels = 6; |
| + |
| +audit.define( |
| + { |
| + label: 'test', |
| + description: |
| + 'downmixing an 8-channel source connected to a JavaScriptAudioNode with 2-channel input' |
|
hongchan
2017/02/24 23:12:46
This needs to be wrapped.
Raymond Toy
2017/02/24 23:18:10
By doing '...' + '...'?
BTW, clang-format left it
hongchan
2017/02/24 23:42:46
I would try rephrase it first, and use '+' to brea
Raymond Toy
2017/02/27 17:31:22
Done.
|
| + }, |
| + (task, should) => { |
| + runJSNodeTest(should).then(() => task.done()); |
| + }); |
| + |
| +audit.run(); |
| </script> |
