Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Unified Diff: extensions/renderer/storage_area.h

Issue 2718543004: [Extensions Bindings] Add ChromeSetting custom type (Closed)
Patch Set: . Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/renderer/storage_area.h
diff --git a/extensions/renderer/storage_area.h b/extensions/renderer/storage_area.h
index 159fd9e5f77657eb34e9d63cdbcfda9e933e1608..5906da20c9a9b511a6304844bb19764f7fb0af7c 100644
--- a/extensions/renderer/storage_area.h
+++ b/extensions/renderer/storage_area.h
@@ -5,7 +5,6 @@
#ifndef EXTENSIONS_RENDERER_STORAGE_AREA_H_
#define EXTENSIONS_RENDERER_STORAGE_AREA_H_
-#include <map>
#include <string>
#include "base/macros.h"
@@ -17,8 +16,8 @@ class Arguments;
}
namespace extensions {
+class APIEventHandler;
class APIRequestHandler;
-class APISignature;
class APITypeReferenceMap;
// Implementation of the storage.StorageArea custom type used in the
@@ -35,28 +34,19 @@ class StorageArea {
v8::Local<v8::Context> context,
const std::string& property_name,
APIRequestHandler* request_handler,
+ APIEventHandler* event_handler,
APITypeReferenceMap* type_refs);
void HandleFunctionCall(const std::string& method_name,
gin::Arguments* arguments);
private:
- // Returns the schema associated with the specified function.
- // TODO(devlin): Other custom types will need this, too; move it out of here
- // when more exist.
- const APISignature& GetFunctionSchema(base::StringPiece api_name,
- base::StringPiece type_name,
- base::StringPiece function_name);
-
APIRequestHandler* request_handler_;
const APITypeReferenceMap* type_refs_;
std::string name_;
- // TODO(devlin): See GetFunctionSchema.
- std::map<std::string, std::unique_ptr<APISignature>> signatures_;
-
DISALLOW_COPY_AND_ASSIGN(StorageArea);
};

Powered by Google App Engine
This is Rietveld 408576698