Add support for building Ubuntu/Trusty sysroot images.

Add support for building Ubuntu/Trusty sysroot images.

The main reason for this is to support cross building for
ARM on Trusty machines (where the sysroot should match the
cross compiler version).

Rename the main sysroot creator script and source it in the
trust and wheezy scripts that are actually runnable.

This should make it easy to create a script for Debian/Jesse
when it is released without duplicating code.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270253

[Lei Zhang, 2014-05-13 02:16:05]

https://codereview.chromium.org/271853003/diff/40001/chrome/installer/linux/s...
File chrome/installer/linux/sysroot_scripts/sysroot-creator.sh (right):

https://codereview.chromium.org/271853003/diff/40001/chrome/installer/linux/s...
chrome/installer/linux/sysroot_scripts/sysroot-creator.sh:5: #@ This script
builds a Debian sysroot impages for building Google Chrome.
typo: impages

https://codereview.chromium.org/271853003/diff/40001/chrome/installer/linux/s...
chrome/installer/linux/sysroot_scripts/sysroot-creator.sh:5: #@ This script
builds a Debian sysroot impages for building Google Chrome.
This script no longer runs on its own. Can you add a comment to explain how this
works now?

https://codereview.chromium.org/271853003/diff/40001/chrome/installer/linux/s...
chrome/installer/linux/sysroot_scripts/sysroot-creator.sh:129: CHROME_DIR=$(cd
${SCRIPT_DIR}/../../.. && pwd)
quotes for the arguments to cd

https://codereview.chromium.org/271853003/diff/40001/chrome/installer/linux/s...
chrome/installer/linux/sysroot_scripts/sysroot-creator.sh:131: mkdir -p
${BUILD_DIR}
Since we are no longer running Cleanup(), should we print out a notification to
remind the user where these files are?

[Sam Clegg, 2014-05-13 18:43:49]

Also added a basic test.

https://codereview.chromium.org/271853003/diff/40001/chrome/installer/linux/s...
File chrome/installer/linux/sysroot_scripts/sysroot-creator.sh (right):

https://codereview.chromium.org/271853003/diff/40001/chrome/installer/linux/s...
chrome/installer/linux/sysroot_scripts/sysroot-creator.sh:5: #@ This script
builds a Debian sysroot impages for building Google Chrome.
On 2014/05/13 02:16:05, Lei Zhang wrote:
> typo: impages

Done.

https://codereview.chromium.org/271853003/diff/40001/chrome/installer/linux/s...
chrome/installer/linux/sysroot_scripts/sysroot-creator.sh:5: #@ This script
builds a Debian sysroot impages for building Google Chrome.
On 2014/05/13 02:16:05, Lei Zhang wrote:
> This script no longer runs on its own. Can you add a comment to explain how
this
> works now?

Done.

https://codereview.chromium.org/271853003/diff/40001/chrome/installer/linux/s...
chrome/installer/linux/sysroot_scripts/sysroot-creator.sh:129: CHROME_DIR=$(cd
${SCRIPT_DIR}/../../.. && pwd)
On 2014/05/13 02:16:05, Lei Zhang wrote:
> quotes for the arguments to cd

Done.

https://codereview.chromium.org/271853003/diff/40001/chrome/installer/linux/s...
chrome/installer/linux/sysroot_scripts/sysroot-creator.sh:131: mkdir -p
${BUILD_DIR}
On 2014/05/13 02:16:05, Lei Zhang wrote:
> Since we are no longer running Cleanup(), should we print out a notification
to
> remind the user where these files are?

Done.

[Lei Zhang, 2014-05-13 19:57:53]

https://codereview.chromium.org/271853003/diff/50001/chrome/installer/linux/s...
File chrome/installer/linux/sysroot_scripts/packagelist.wheezy.arm (right):

https://codereview.chromium.org/271853003/diff/50001/chrome/installer/linux/s...
chrome/installer/linux/sysroot_scripts/packagelist.wheezy.arm:1:
main/e/e2fsprogs/comerr-dev_2.1-1.42.5-1.1_armhf.deb
743b38a2078021023cc3e31f0e5983780aa8c90dab09e085a58ca06f0559ff5b
Did you mean to add the checksums?

https://codereview.chromium.org/271853003/diff/50001/chrome/installer/linux/s...
File chrome/installer/linux/sysroot_scripts/sysroot-creator-test.sh (right):

https://codereview.chromium.org/271853003/diff/50001/chrome/installer/linux/s...
chrome/installer/linux/sysroot_scripts/sysroot-creator-test.sh:2: # Copyright
(c) 2013 The Chromium Authors. All rights reserved.
no (c), also it's half way through 2014 now ;)

https://codereview.chromium.org/271853003/diff/50001/chrome/installer/linux/s...
chrome/installer/linux/sysroot_scripts/sysroot-creator-test.sh:14:
$SCRIPT_DIR/sysroot-creator-trusty.sh UpdatePackageListsAmd64
quotes

https://codereview.chromium.org/271853003/diff/50001/chrome/installer/linux/s...
File chrome/installer/linux/sysroot_scripts/sysroot-creator.sh (right):

https://codereview.chromium.org/271853003/diff/50001/chrome/installer/linux/s...
chrome/installer/linux/sysroot_scripts/sysroot-creator.sh:5: # This script is
should not be run directly but sourced by the other
s/is should/should/

[Sam Clegg, 2014-05-13 20:13:21]

https://codereview.chromium.org/271853003/diff/50001/chrome/installer/linux/s...
File chrome/installer/linux/sysroot_scripts/packagelist.wheezy.arm (right):

https://codereview.chromium.org/271853003/diff/50001/chrome/installer/linux/s...
chrome/installer/linux/sysroot_scripts/packagelist.wheezy.arm:1:
main/e/e2fsprogs/comerr-dev_2.1-1.42.5-1.1_armhf.deb
743b38a2078021023cc3e31f0e5983780aa8c90dab09e085a58ca06f0559ff5b
On 2014/05/13 19:57:53, Lei Zhang wrote:
> Did you mean to add the checksums?

Oops.  Not sure how that happened.  Done.

https://codereview.chromium.org/271853003/diff/50001/chrome/installer/linux/s...
File chrome/installer/linux/sysroot_scripts/sysroot-creator-test.sh (right):

https://codereview.chromium.org/271853003/diff/50001/chrome/installer/linux/s...
chrome/installer/linux/sysroot_scripts/sysroot-creator-test.sh:2: # Copyright
(c) 2013 The Chromium Authors. All rights reserved.
On 2014/05/13 19:57:53, Lei Zhang wrote:
> no (c), also it's half way through 2014 now ;)

Done.

https://codereview.chromium.org/271853003/diff/50001/chrome/installer/linux/s...
chrome/installer/linux/sysroot_scripts/sysroot-creator-test.sh:14:
$SCRIPT_DIR/sysroot-creator-trusty.sh UpdatePackageListsAmd64
On 2014/05/13 19:57:53, Lei Zhang wrote:
> quotes

Done.

https://codereview.chromium.org/271853003/diff/50001/chrome/installer/linux/s...
File chrome/installer/linux/sysroot_scripts/sysroot-creator.sh (right):

https://codereview.chromium.org/271853003/diff/50001/chrome/installer/linux/s...
chrome/installer/linux/sysroot_scripts/sysroot-creator.sh:5: # This script is
should not be run directly but sourced by the other
On 2014/05/13 19:57:53, Lei Zhang wrote:
> s/is should/should/

Done.

[Lei Zhang, 2014-05-13 20:24:47]

lgtm

[Sam Clegg, 2014-05-13 20:51:34]

The CQ bit was checked by sbc@chromium.org

[commit-bot: I haz the power, 2014-05-13 20:53:02]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/sbc@chromium.org/271853003/70001

[commit-bot: I haz the power, 2014-05-13 23:57:51]

Change committed as 270253