Fixed issue in MallocHooks where a MallocHookScope was accidentally removed during a merge, causing…

Fixed issue in MallocHooks where a MallocHookScope was accidentally removed during a merge, causing a deadlock in the hooks. Also turned off stack trace collection in a test that was timing out as a result of the stack trace collection.


Updated MallocHooks to collect stack traces when memory is allocated.

BUG=
R=johnmccutchan@google.com

Committed: https://github.com/dart-lang/sdk/commit/44a9a4ede3aeec288396d1c169734c4d58853e21

[bkonyi, 2017-02-23 21:37:04]

bkonyi@google.com changed reviewers:
+ johnmccutchan@google.com, zra@google.com

[bkonyi, 2017-02-23 21:37:04]

This is a re-submission of the stack trace collection CL I tried to land
earlier. I've placed comments where the relevant changes in this CL are.

https://codereview.chromium.org/2718523003/diff/1/runtime/vm/malloc_hooks.cc
File runtime/vm/malloc_hooks.cc (right):

https://codereview.chromium.org/2718523003/diff/1/runtime/vm/malloc_hooks.cc#...
runtime/vm/malloc_hooks.cc:450: MallocHookScope mhs;
Note: This MallocHookScope was accidentally removed during a merge and was
causing a deadlock.

https://codereview.chromium.org/2718523003/diff/1/runtime/vm/object_test.cc
File runtime/vm/object_test.cc (left):

https://codereview.chromium.org/2718523003/diff/1/runtime/vm/object_test.cc#o...
runtime/vm/object_test.cc:2711: ISOLATE_UNIT_TEST_CASE(CodeImmutability) {
Note: Change added in this CL.

[Cutch, 2017-02-23 22:16:24]

lgtm

[bkonyi, 2017-02-24 02:58:58]

Description was changed from

==========
Fixed issue in MallocHooks where a MallocHookScope was accidentally removed
during a merge, causing a deadlock in the hooks. Also turned off stack trace
collection in a test that was timing out as a result of the stack trace
collection.


Updated MallocHooks to collect stack traces when memory is allocated.

BUG=
==========

to

==========
Fixed issue in MallocHooks where a MallocHookScope was accidentally removed
during a merge, causing a deadlock in the hooks. Also turned off stack trace
collection in a test that was timing out as a result of the stack trace
collection.


Updated MallocHooks to collect stack traces when memory is allocated.

BUG=
R=johnmccutchan@google.com

Committed:
https://github.com/dart-lang/sdk/commit/44a9a4ede3aeec288396d1c169734c4d58853e21
==========

[bkonyi, 2017-02-24 02:58:59]

Committed patchset #2 (id:20001) manually as
44a9a4ede3aeec288396d1c169734c4d58853e21 (presubmit successful).