Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(639)

Unified Diff: runtime/vm/flow_graph_builder.cc

Issue 2718513002: Void is not required to be `null` anymore. (Closed)
Patch Set: Update Kernel code. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/compiler/lib/src/ssa/nodes.dart ('k') | runtime/vm/flow_graph_compiler_arm.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/flow_graph_builder.cc
diff --git a/runtime/vm/flow_graph_builder.cc b/runtime/vm/flow_graph_builder.cc
index 53ae53b110010e69e75205afc4e2370c6aff297b..946978ea8f44ebdae6d7b26b1e5cb2c53e1a111a 100644
--- a/runtime/vm/flow_graph_builder.cc
+++ b/runtime/vm/flow_graph_builder.cc
@@ -1259,8 +1259,9 @@ bool EffectGraphVisitor::CanSkipTypeCheck(TokenPosition token_pos,
return false;
}
- // Any type is more specific than the dynamic type and than the Object type.
- if (dst_type.IsDynamicType() || dst_type.IsObjectType()) {
+ // Any type is more specific than the dynamic type, the Object type, or void.
+ if (dst_type.IsDynamicType() || dst_type.IsObjectType() ||
+ dst_type.IsVoidType()) {
return true;
}
« no previous file with comments | « pkg/compiler/lib/src/ssa/nodes.dart ('k') | runtime/vm/flow_graph_compiler_arm.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698