Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(260)

Unified Diff: media/base/demuxer.h

Issue 2718483003: Use base::Optional for selected video track. (Closed)
Patch Set: rebase Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | media/base/media_url_demuxer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/base/demuxer.h
diff --git a/media/base/demuxer.h b/media/base/demuxer.h
index 71cdc6d14a91518950aa7d1dc943568937dff761..799408341637dbb052fa5aa4f14b232fe001e9a2 100644
--- a/media/base/demuxer.h
+++ b/media/base/demuxer.h
@@ -11,6 +11,7 @@
#include <vector>
#include "base/macros.h"
+#include "base/optional.h"
#include "base/time/time.h"
#include "media/base/data_source.h"
#include "media/base/demuxer_stream.h"
@@ -143,12 +144,13 @@ class MEDIA_EXPORT Demuxer : public MediaResource {
virtual void OnEnabledAudioTracksChanged(
const std::vector<MediaTrack::Id>& track_ids,
- base::TimeDelta currTime) = 0;
+ base::TimeDelta curr_time) = 0;
- // |track_ids| is either empty or contains a single video track id.
+ // |track_id| either contains the selected video track id or is null,
+ // indicating that all video tracks are deselected/disabled.
virtual void OnSelectedVideoTrackChanged(
- const std::vector<MediaTrack::Id>& track_ids,
- base::TimeDelta currTime) = 0;
+ base::Optional<MediaTrack::Id> track_id,
+ base::TimeDelta curr_time) = 0;
private:
DISALLOW_COPY_AND_ASSIGN(Demuxer);
« no previous file with comments | « no previous file | media/base/media_url_demuxer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698