Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Unified Diff: media/base/pipeline.h

Issue 2718483003: Use base::Optional for selected video track. (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/base/pipeline.h
diff --git a/media/base/pipeline.h b/media/base/pipeline.h
index cf3c69ee136abeeec3b51de73087573575b26686..629658320dbe30a16a8977eb779cffdd37404449 100644
--- a/media/base/pipeline.h
+++ b/media/base/pipeline.h
@@ -82,10 +82,10 @@ class MEDIA_EXPORT Pipeline {
virtual void OnEnabledAudioTracksChanged(
const std::vector<MediaTrack::Id>& enabledTrackIds) = 0;
- // |trackId| either empty, which means no video track is selected, or contain
- // one element - the selected video track id.
+ // |trackId| is either empty, which means no video track is selected, or
watk 2017/02/23 20:57:54 s/trackId/selectedTrackId/ Also why are we using
servolk 2017/02/23 21:15:48 Done.
+ // contains the selected video track id.
virtual void OnSelectedVideoTrackChanged(
- const std::vector<MediaTrack::Id>& selectedTrackId) = 0;
+ base::Optional<MediaTrack::Id> selectedTrackId) = 0;
// Stops the pipeline. This is a blocking function.
// If the pipeline is started, it must be stopped before destroying it.

Powered by Google App Engine
This is Rietveld 408576698