components/ntp_snippets/remote/remote_suggestions_provider_impl_unittest.cc - Issue 2718453002: ntp_snippets: default to staging API on dev/canary

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/ntp_snippets/remote/remote_suggestions_provider_impl_unittest.cc

Issue 2718453002: ntp_snippets: default to staging API on dev/canary (Closed)

Patch Set: Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/ntp_snippets/remote/remote_suggestions_fetcher_unittest.cc ('K') | « components/ntp_snippets/remote/remote_suggestions_fetcher_unittest.cc ('k') | ios/chrome/browser/ntp_snippets/ios_chrome_content_suggestions_service_factory.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/ntp_snippets/remote/remote_suggestions_provider_impl_unittest.cc

diff --git a/components/ntp_snippets/remote/remote_suggestions_provider_impl_unittest.cc b/components/ntp_snippets/remote/remote_suggestions_provider_impl_unittest.cc

index 84349c862695b8acc838a367cc09420ede36a22a..40b1d1feccab0688363c4945575916eeb7d92c63 100644

--- a/components/ntp_snippets/remote/remote_suggestions_provider_impl_unittest.cc

+++ b/components/ntp_snippets/remote/remote_suggestions_provider_impl_unittest.cc

@@ -414,7 +414,8 @@ class RemoteSuggestionsProviderImplTest : public ::testing::Test {

auto suggestions_fetcher = base::MakeUnique<RemoteSuggestionsFetcher>(

utils_.fake_signin_manager(), /*token_service=*/nullptr,

std::move(request_context_getter), utils_.pref_service(), nullptr,

- base::Bind(&ParseJson), kAPIKey, &user_classifier_);

+ base::Bind(&ParseJson), GetFetchEndpoint(true), kAPIKey,

jkrcal 2017/02/23 13:25:22 nit: could you please add /*is_stable_or_beta_chan

sfiera 2017/02/23 13:28:47 Done.

+ &user_classifier_);

suggestions_fetcher_ = suggestions_fetcher.get();

auto image_fetcher = base::MakeUnique<NiceMock<MockImageFetcher>>();