Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(609)

Unified Diff: components/search_provider_logos/logo_tracker.cc

Issue 2718443002: Network traffic annotation added to logo_tracker. (Closed)
Patch Set: Annotation updated. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/search_provider_logos/logo_tracker.cc
diff --git a/components/search_provider_logos/logo_tracker.cc b/components/search_provider_logos/logo_tracker.cc
index d5e10a61eb8fd4e8cb6a6de796f4fbf58123c807..79c840861e4aa2473ed81896e25b621120068756 100644
--- a/components/search_provider_logos/logo_tracker.cc
+++ b/components/search_provider_logos/logo_tracker.cc
@@ -17,6 +17,7 @@
#include "components/search_provider_logos/switches.h"
#include "net/http/http_response_headers.h"
#include "net/http/http_status_code.h"
+#include "net/traffic_annotation/network_traffic_annotation.h"
#include "net/url_request/url_fetcher.h"
#include "net/url_request/url_request_context_getter.h"
#include "net/url_request/url_request_status.h"
@@ -226,7 +227,29 @@ void LogoTracker::FetchLogo() {
logo_url_, fingerprint, wants_cta_, transparent_);
}
- fetcher_ = net::URLFetcher::Create(url, net::URLFetcher::GET, this);
+ net::NetworkTrafficAnnotationTag traffic_annotation =
+ net::DefineNetworkTrafficAnnotation("logo_tracker", R"(
+ semantics {
+ sender: "Logo Tracker"
+ description:
+ "Provides the logo image for a search provider (e.g. Google or "
+ "Yahoo!)."
+ trigger: "Displaying the new tab page on iOS or Android."
+ data: "..."
+ destination: OTHER
+ }
+ policy {
+ cookies_allowed: true
+ cookies_store: "user"
+ setting:
+ "Choosing a non-Google search engine in Chromium settings under "
Marc Treib 2017/02/24 17:05:51 Should this be "Chrome" rather than "Chromium"? I
Ramin Halavati 2017/02/27 09:43:11 We have started to use Chromium instead and will u
+ "'Search Engine' will disable this feature."
+ policy_exception_justification:
+ "Not implemented, considered not useful as it does not upload any"
+ "data and just downloads a logo image."
+ })");
+ fetcher_ = net::URLFetcher::Create(url, net::URLFetcher::GET, this,
+ traffic_annotation);
fetcher_->SetRequestContext(request_context_getter_.get());
data_use_measurement::DataUseUserData::AttachToFetcher(
fetcher_.get(),
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698