Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(389)

Unified Diff: src/heap.h

Issue 271843005: Simplify ConfigureHeap and change --max_new_space_size to --max_semi_space_size. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/heap.h
diff --git a/src/heap.h b/src/heap.h
index 9c100fcf1fc5aabf89d0da6a4aa69a175ebb461d..75eefb7ce1e28596e46da71e2e016b05948af1e9 100644
--- a/src/heap.h
+++ b/src/heap.h
@@ -546,12 +546,12 @@ enum ArrayStorageAllocationMode {
class Heap {
public:
- // Configure heap size before setup. Return false if the heap has been
+ // Configure heap size in MB before setup. Return false if the heap has been
// set up already.
bool ConfigureHeap(int max_semispace_size,
- intptr_t max_old_space_size,
- intptr_t max_executable_size,
- intptr_t code_range_size);
+ int max_old_space_size,
+ int max_executable_size,
+ int code_range_size);
bool ConfigureHeapDefault();
// Prepares the heap, setting up memory areas that are needed in the isolate
@@ -1072,25 +1072,39 @@ class Heap {
static const intptr_t kMinimumOldGenerationAllocationLimit =
8 * (Page::kPageSize > MB ? Page::kPageSize : MB);
- static const int kLumpOfMemory = (i::kPointerSize / 4) * i::MB;
+ static const int kPointerMultiplier = i::kPointerSize / 4;
- // The new space size has to be a power of 2.
- static const int kMaxNewSpaceSizeLowMemoryDevice = 2 * kLumpOfMemory;
- static const int kMaxNewSpaceSizeMediumMemoryDevice = 8 * kLumpOfMemory;
- static const int kMaxNewSpaceSizeHighMemoryDevice = 16 * kLumpOfMemory;
- static const int kMaxNewSpaceSizeHugeMemoryDevice = 16 * kLumpOfMemory;
+ // The new space size has to be a power of 2. Sizes are in MB.
+ static const int kMaxSemiSpaceSizeLowMemoryDevice =
+ 1 * kPointerMultiplier;
+ static const int kMaxSemiSpaceSizeMediumMemoryDevice =
+ 4 * kPointerMultiplier;
+ static const int kMaxSemiSpaceSizeHighMemoryDevice =
+ 8 * kPointerMultiplier;
+ static const int kMaxSemiSpaceSizeHugeMemoryDevice =
+ 8 * kPointerMultiplier;
// The old space size has to be a multiple of Page::kPageSize.
- static const int kMaxOldSpaceSizeLowMemoryDevice = 128 * kLumpOfMemory;
- static const int kMaxOldSpaceSizeMediumMemoryDevice = 256 * kLumpOfMemory;
- static const int kMaxOldSpaceSizeHighMemoryDevice = 512 * kLumpOfMemory;
- static const int kMaxOldSpaceSizeHugeMemoryDevice = 700 * kLumpOfMemory;
+ // Sizes are in MB.
+ static const int kMaxOldSpaceSizeLowMemoryDevice =
+ 128 * kPointerMultiplier;
+ static const int kMaxOldSpaceSizeMediumMemoryDevice =
+ 256 * kPointerMultiplier;
+ static const int kMaxOldSpaceSizeHighMemoryDevice =
+ 512 * kPointerMultiplier;
+ static const int kMaxOldSpaceSizeHugeMemoryDevice =
+ 700 * kPointerMultiplier;
// The executable size has to be a multiple of Page::kPageSize.
- static const int kMaxExecutableSizeLowMemoryDevice = 128 * kLumpOfMemory;
- static const int kMaxExecutableSizeMediumMemoryDevice = 256 * kLumpOfMemory;
- static const int kMaxExecutableSizeHighMemoryDevice = 512 * kLumpOfMemory;
- static const int kMaxExecutableSizeHugeMemoryDevice = 700 * kLumpOfMemory;
+ // Sizes are in MB.
+ static const int kMaxExecutableSizeLowMemoryDevice =
+ 128 * kPointerMultiplier;
+ static const int kMaxExecutableSizeMediumMemoryDevice =
+ 256 * kPointerMultiplier;
+ static const int kMaxExecutableSizeHighMemoryDevice =
+ 512 * kPointerMultiplier;
+ static const int kMaxExecutableSizeHugeMemoryDevice =
+ 700 * kPointerMultiplier;
intptr_t OldGenerationAllocationLimit(intptr_t old_gen_size) {
intptr_t limit = FLAG_stress_compaction

Powered by Google App Engine
This is Rietveld 408576698