Remove SharedBitmapManager global in ui/compositor

Remove SharedBitmapManager global in ui/compositor

Globals prevent ui::Compositor from being used in multiple threads.

BUG=None
R=jbauman@chromium.org, sky@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269153

[piman, 2014-05-08 01:34:56]

Begun, the static wars have.

https://codereview.chromium.org/271843002/diff/1/content/browser/compositor/i...
File content/browser/compositor/image_transport_factory.h (left):

https://codereview.chromium.org/271843002/diff/1/content/browser/compositor/i...
content/browser/compositor/image_transport_factory.h:68: virtual
ui::ContextFactory* AsContextFactory() = 0;
Slightly unrelated, but the only place this is called is where we have the
concrete type, so it's not needed.

[jbauman, 2014-05-08 01:43:48]

lgtm. I guess we're going to be getting rid of g_factory and g_implicit_factory
or something?

[piman, 2014-05-08 01:46:07]

On 2014/05/08 01:43:48, jbauman wrote:
> lgtm. I guess we're going to be getting rid of g_factory and
g_implicit_factory
> or something?

That's the plan, or at least move it up some layers (aura?), so that at least
ui::Compositor is free of statics.

Full dependency-injection would be nice, but is more work, and I don't think
it's needed yet.

[piman, 2014-05-08 01:46:26]

The CQ bit was checked by piman@chromium.org

[commit-bot: I haz the power, 2014-05-08 01:50:02]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/piman@chromium.org/271843002/1

[piman, 2014-05-08 04:34:07]

Missed mojo. +sky for OWNERS

[sky, 2014-05-08 15:01:42]

LGTM - thanks!

[piman, 2014-05-08 18:07:25]

The CQ bit was checked by piman@chromium.org

[commit-bot: I haz the power, 2014-05-08 18:12:25]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/piman@chromium.org/271843002/20001

[piman, 2014-05-09 02:22:03]

Committed patchset #2 manually as r269153 (presubmit successful).