Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Unified Diff: milo/appengine/buildbot/build.go

Issue 2718373004: Milo: Print raw json for buildbot build properties (Closed)
Patch Set: Rebase Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: milo/appengine/buildbot/build.go
diff --git a/milo/appengine/buildbot/build.go b/milo/appengine/buildbot/build.go
index c6f7e0c977bd902aaa08dbc5e956b1119dfebc83..5709bc28729bd7848bc9ebad77f95590d82b82d7 100644
--- a/milo/appengine/buildbot/build.go
+++ b/milo/appengine/buildbot/build.go
@@ -335,18 +335,6 @@ func parseProp(prop map[string]Prop, k string, v interface{}) (string, bool) {
if vf, ok := v.(float64); ok {
return time.Unix(int64(vf), 0).UTC().Format(time.RFC3339), true
}
- case "buildbucket":
- var b map[string]interface{}
- json.Unmarshal([]byte(v.(string)), &b)
- if b["build"] == nil {
- return "", false
- }
- build := b["build"].(map[string]interface{})
- id := build["id"]
- if id == nil {
- return "", false
- }
- return fmt.Sprintf("https://cr-buildbucket.appspot.com/b/%s", id.(string)), true
case "issue":
if rv, ok := prop["rietveld"]; ok {
rietveld := rv.Value.(string)

Powered by Google App Engine
This is Rietveld 408576698